Skip to content

Conversation

@iM-GeeKy
Copy link
Collaborator

@iM-GeeKy iM-GeeKy commented Jun 5, 2025

Motivation

This pull request resolves #455 and #456 and also will take the startYear and endYear parameters into consideration so that if they are provided only the range between those years will be drawn which will be more efficient.

Disclaimer

You can now supply any arbitrary value for startYear and endYear BUT if a large range is specified say startYear=1400 and endYear=2400 then the initial scrollToOffset will not occur as it seems like the virtualization of the flatlist may scroll to an offset that is not yet in memory (I'm not 100% sure, but we can address that issue separately).

Before

Screen.Recording.2025-06-06.at.5.45.34.AM.mov

After

Screen.Recording.2025-06-05.at.1.02.57.PM.mov

Start and End Year Specified (1950 to 2030)

Screen.Recording.2025-06-06.at.5.50.20.AM.mov

@iM-GeeKy iM-GeeKy requested a review from RichardLindhout June 5, 2025 18:06
@iM-GeeKy iM-GeeKy changed the title Fix start end year (DO NOT MERGE) Fix start end year Jun 5, 2025
@iM-GeeKy iM-GeeKy changed the title (DO NOT MERGE) Fix start end year ‼️ DO NOT MERGE ‼️ Fix start end year Jun 5, 2025
@iM-GeeKy iM-GeeKy changed the title ‼️ DO NOT MERGE ‼️ Fix start end year Fix start end year Jun 6, 2025
@iM-GeeKy iM-GeeKy merged commit 615819e into master Jun 6, 2025
5 checks passed
@iM-GeeKy iM-GeeKy deleted the fix-start-end-year branch June 6, 2025 09:59
@kuriel-dev
Copy link

      startYear={DateTime.now().year - 130}
      endYear={DateTime.now().year- 1}

When setting endYear lower than current, the UI breaks.

version ^0.22.49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The selection of the year 1924 and below does not work

3 participants