Fix the way href's are being set in DefaultAuthForms #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount the route defined for the Auth object
|
Added another commit, as I appear to miss a couple of redirects in the first one - became obvious when I tried to use the 2FA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that url manipulation in
DefaultAuthFormsinauth.pyis missing any kind of consideration for theroutesetup in theAuthobject. This results in the links failing every time if therouteis anything but the defaultroute='auth'.This PR aims at fixing this by replacing static strings with dynamically created urls using the
URL()helper and taking into consideration the value of therouteparamter defined in theAuthobject.