Skip to content

Commit 9ea5a51

Browse files
authored
Merge pull request #31 from web3privacy/fix/filter-ui
Add custom `Filter` modal to support mobile
2 parents 951eefa + ff5cbd4 commit 9ea5a51

File tree

4 files changed

+255
-207
lines changed

4 files changed

+255
-207
lines changed

src/components/ui/dropdown-menu.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const DropdownMenuSubContent = React.forwardRef<
4343
<DropdownMenuPrimitive.SubContent
4444
ref={ref}
4545
className={cn(
46-
'z-50 min-w-[8rem] overflow-hidden border border-stone-200 bg-white p-1 text-stone-950 shadow-lg data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 dark:border-stone-800 dark:bg-stone-950 dark:text-stone-50',
46+
'z-[100] min-w-[8rem] max-w-[calc(100vw-1rem)] overflow-hidden border border-stone-200 bg-white p-1 text-stone-950 shadow-lg data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 dark:border-stone-800 dark:bg-stone-950 dark:text-stone-50',
4747
className
4848
)}
4949
{...props}
@@ -60,9 +60,12 @@ const DropdownMenuContent = React.forwardRef<
6060
ref={ref}
6161
sideOffset={sideOffset}
6262
className={cn(
63-
'z-50 min-w-[8rem] overflow-hidden border border-stone-200 bg-white p-1 text-stone-950 shadow-md data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 dark:border-stone-800 dark:bg-stone-950 dark:text-stone-50',
63+
'z-[100] min-w-[8rem] max-w-[calc(100vw-1rem)] overflow-hidden border border-stone-200 bg-white p-1 text-stone-950 shadow-md data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 dark:border-stone-800 dark:bg-stone-950 dark:text-stone-50',
6464
className
6565
)}
66+
collisionPadding={8}
67+
side="bottom"
68+
align="start"
6669
{...props}
6770
/>
6871
</DropdownMenuPrimitive.Portal>

src/components/ui/idea-card.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -200,32 +200,32 @@ const IdeaCard: React.FC<IdeaCardProps> = ({
200200

201201
{renderFeatures()}
202202

203-
<div className="flex justify-between items-center my-3">
204-
<div className="flex flex-wrap gap-1 w-2/3">
203+
<div className="flex flex-col sm:flex-row sm:justify-between sm:items-center my-3 gap-3">
204+
<div className="flex flex-wrap gap-1 sm:w-2/3">
205205
{categories.map((category, index) => (
206-
<Badge key={index} variant="secondary" className="mr-1 mb-1">
206+
<Badge key={index} variant="secondary" className="mr-1 mb-1 text-xs">
207207
{category}
208208
</Badge>
209209
))}
210210
</div>
211-
<div className="w-1/3 text-xs text-end flex justify-end space-x-3">
211+
<div className="sm:w-1/3 text-xs flex justify-start sm:justify-end space-x-3">
212212
{github && (
213-
<a href={github} target="_blank" rel="noopener noreferrer">
213+
<a href={github} target="_blank" rel="noopener noreferrer" aria-label="View on GitHub">
214214
<Github className="w-5 h-5" />
215215
</a>
216216
)}
217217
{website && (
218-
<a href={website} target="_blank" rel="noopener noreferrer">
218+
<a href={website} target="_blank" rel="noopener noreferrer" aria-label="Visit website">
219219
<Globe className="w-5 h-5" />
220220
</a>
221221
)}
222222
<Dialog>
223223
<DialogTrigger asChild>
224-
<button className="focus:outline-none">
224+
<button className="focus:outline-none" aria-label="Share this idea">
225225
<Share2 className="w-5 h-5" />
226226
</button>
227227
</DialogTrigger>
228-
<DialogContent>
228+
<DialogContent className="sm:max-w-md">
229229
<DialogHeader>
230230
<DialogTitle>Share this idea</DialogTitle>
231231
<DialogDescription>

0 commit comments

Comments
 (0)