[ WIP ] width, height, dpi from NFT marker. #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- event dispatching 'dataMarker'
Member
Author
|
The example fails to detect and track the pinball image. Probably my implementation is partially wrong because is returning a struct without a id_patt, i will fix this. |
Member
Author
|
I will not merge this PR, i have done naother test with this branch https://github.com/kalwalt/jsartoolkitNFT/tree/feature-position-v2 the repositioning of the model works as i will expect, but with a lot of jttering of the model. I'm not satisfied with this result. I think that this jttering is caused by the continuosly updating of the position. I think instead of retrieve dpi, width and height of the marker we should get these values at the init, while the loading of the NFT marker is ended. I will work on this on a new and updated branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to get width, height and dpi from the NFT marker data to use for positioning the three.js model in the 3d space.
ref PR kalwalt/jsartoolkit5#42