Skip to content

Conversation

dcsaszar
Copy link
Contributor

@dcsaszar dcsaszar commented May 12, 2025

Reimplemented #432 including feedback.

Based on master before #650 (see #650 (comment)) to allow for local testing.

gzip-size can be uninstalled. I did not include this commit b/c it creates a conflict with changes on master after my base.

@valscion
Copy link
Member

Thanks! I'll take a closer look when possible, right now I'm pressed on time

@dcsaszar
Copy link
Contributor Author

As long as we can make it within the next four years, we'd still beat #432.

Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me, great work here! I'll still take this for a spin when I can to test it out.

Could you add a changelog entry as a new feature?

@dcsaszar dcsaszar requested a review from valscion May 19, 2025 08:38
Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems to work nicely 👍

@valscion valscion merged commit 783ee10 into webpack-contrib:master May 21, 2025
5 checks passed
@dcsaszar dcsaszar deleted the dave-feat-brotli branch May 21, 2025 09:57
dcsaszar added a commit to dcsaszar/webpack-bundle-analyzer that referenced this pull request May 23, 2025
valscion pushed a commit that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants