This repository was archived by the owner on Jul 13, 2021. It is now read-only.
Fix bugs when using the server option together with different client/server URLs#108
Open
hedgepigdaniel wants to merge 2 commits intowebpack-contrib:masterfrom
Open
Fix bugs when using the server option together with different client/server URLs#108hedgepigdaniel wants to merge 2 commits intowebpack-contrib:masterfrom
hedgepigdaniel wants to merge 2 commits intowebpack-contrib:masterfrom
Conversation
|
Can we get this merged? this would be super helpful |
Author
|
You would be better off asking here: https://github.com/shellscape/webpack-hot-client |
Author
|
Or use my fork, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Having a different browser address and server address is useful if there is a proxy in between. The server option is useful because it removes the need to have two servers and two ports.
There are two bugs fixed:
even though the provided server is already listening on a host/port
host.clientsettingBreaking Changes
None
Additional Info