Skip to content
This repository was archived by the owner on Jul 13, 2021. It is now read-only.

Comments

Fix bugs when using the server option together with different client/server URLs#108

Open
hedgepigdaniel wants to merge 2 commits intowebpack-contrib:masterfrom
hedgepigdaniel:bug/server-and-url
Open

Fix bugs when using the server option together with different client/server URLs#108
hedgepigdaniel wants to merge 2 commits intowebpack-contrib:masterfrom
hedgepigdaniel:bug/server-and-url

Conversation

@hedgepigdaniel
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Having a different browser address and server address is useful if there is a proxy in between. The server option is useful because it removes the need to have two servers and two ports.

There are two bugs fixed:

  • The validation code previously rejected a configuration such as this:
{
  host: {
    client: 'someurl',
  },
  port: {
    client: 80
  },
  server,
}

even though the provided server is already listening on a host/port

  • When the server option was used, the client ignored the host.client setting

Breaking Changes

None

Additional Info

@aaronup
Copy link

aaronup commented Nov 8, 2019

Can we get this merged? this would be super helpful

@hedgepigdaniel
Copy link
Author

You would be better off asking here: https://github.com/shellscape/webpack-hot-client

@hedgepigdaniel
Copy link
Author

Or use my fork, webpack-hmr-client

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants