This repository was archived by the owner on Jul 13, 2021. It is now read-only.
beta: https better server support, client-server port config#85
Merged
shellscape merged 4 commits intomasterfrom Jul 6, 2018
Merged
beta: https better server support, client-server port config#85shellscape merged 4 commits intomasterfrom
shellscape merged 4 commits intomasterfrom
Conversation
Contributor
Author
shellscape
changed the title
Contributor
Author
|
Note that Firefox has special requirements for self-signed certs: https://github.com/webpack-contrib/webpack-hot-client/tree/next#https |
ooflorent
approved these changes
Jul 6, 2018
alexander-akait
approved these changes
Jul 6, 2018
|
Looking good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Clients were having trouble connecting to the
WebSocketserver thatwebpack-hot-clientcreates, when anhttpshost was used.Breaking Changes
None
Additional Info
Resolves #79. This PR would also take precedence over #80 and #83 due to the HTTPS fix needing to refactor how ports and hosts are determined.