Skip to content
This repository was archived by the owner on Jul 13, 2021. It is now read-only.

fix(index): correctly pass args to stats.toJson and cache stats#97

Open
kamijin-fanta wants to merge 2 commits intowebpack-contrib:masterfrom
kamijin-fanta:master
Open

fix(index): correctly pass args to stats.toJson and cache stats#97
kamijin-fanta wants to merge 2 commits intowebpack-contrib:masterfrom
kamijin-fanta:master

Conversation

@kamijin-fanta
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

  • options.stats was not used (it was overwritten)
  • cached results of heavy stats.toJson

Breaking Changes

none

Additional Info

none

@jsf-clabot
Copy link

jsf-clabot commented Aug 1, 2018

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky michael-ciniawsky changed the title fix args passed to stats.toJson / cache json stats fix: correctly pass args to stats.toJson and cache stats Sep 15, 2018
@michael-ciniawsky michael-ciniawsky changed the title fix: correctly pass args to stats.toJson and cache stats fix(index): correctly pass args to stats.toJson and cache stats Sep 15, 2018
@kamijin-fanta
Copy link
Author

@michael-ciniawsky what is the status of this PR?

This was referenced Sep 20, 2019
@hedgepigdaniel
Copy link

@gbiryukov
Copy link

This PR is really valuable and allows to save around 1s on hot reload in large projects.
@shellscape @michael-ciniawsky what needs to be done to merge it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants