refactor: types for client (#5544)

Author: alexander-akait

.cspell.json

@@ -71,7 +71,8 @@
     "eslintcache",
     "hono",
     "privkey",
-    "geomanist"
+    "geomanist",
+    "nodenext"
   ],
   "ignorePaths": [
     "CHANGELOG.md",

client-src/index.js

@@ -1,6 +1,4 @@
 /* global __resourceQuery, __webpack_hash__ */
-/// <reference types="webpack/module" />
-
 // @ts-expect-error
 import hotEmitter from "webpack/hot/emitter.js";
 // @ts-expect-error
@@ -54,10 +52,12 @@ import sendMessage from "./utils/sendMessage.js";
  */
 const decodeOverlayOptions = (overlayOptions) => {
   if (typeof overlayOptions === "object") {
-    for (const property_ of ["warnings", "errors", "runtimeErrors"]) {
+    const requiredOptions = ["warnings", "errors", "runtimeErrors"];
+
+    for (let i = 0; i < requiredOptions.length; i++) {
       const property =
         /** @type {keyof Omit<RawOverlayOptions, "trustedTypesPolicyName">} */
-        (property_);
+        (requiredOptions[i]);
 
       if (typeof overlayOptions[property] === "string") {
         const overlayFilterFunctionString = decodeURIComponent(

client-src/overlay.js

@@ -10,7 +10,8 @@ import ansiHTML from "ansi-html-community";
  */
 // @ts-expect-error
 const getCodePoint = String.prototype.codePointAt
-  ? (input, position) => input.codePointAt(position)
+  ? // @ts-expect-error
+    (input, position) => input.codePointAt(position)
   : (input, position) =>
       (input.charCodeAt(position) - 0xd800) * 0x400 +
       input.charCodeAt(position + 1) -

client-src/progress.js

@@ -23,7 +23,6 @@ export function defineProgressElement() {
       this.animationTimer = null;
     }
 
-    // @ts-expect-error
     #reset() {
       clearTimeout(this.animationTimer);
       this.animationTimer = null;
@@ -44,7 +43,6 @@ export function defineProgressElement() {
       this.#update(this.initialProgress);
     }
 
-    // @ts-expect-error
     static #circularTemplate() {
       return `
         <style>
@@ -111,7 +109,6 @@ export function defineProgressElement() {
       `;
     }
 
-    // @ts-expect-error
     static #linearTemplate() {
       return `
         <style>
@@ -173,7 +170,6 @@ export function defineProgressElement() {
     /**
      * @param {number} percent percent
      */
-    // @ts-expect-error
     #update(percent) {
       const shadowRoot = /** @type {ShadowRoot} */ (this.shadowRoot);
       const element =
@@ -201,7 +197,6 @@ export function defineProgressElement() {
       }
     }
 
-    // @ts-expect-error
     #show() {
       const shadowRoot = /** @type {ShadowRoot} */ (this.shadowRoot);
       const element =
@@ -210,7 +205,6 @@ export function defineProgressElement() {
       element.classList.remove("hidden");
     }
 
-    // @ts-expect-error
     #hide() {
       const shadowRoot = /** @type {ShadowRoot} */ (this.shadowRoot);
       const element =

package-lock.json

@@ -90,7 +90,7 @@
     "@types/node": "^24.0.14",
     "@types/node-forge": "^1.3.1",
     "@types/sockjs-client": "^1.5.1",
-    "@types/trusted-types": "^2.0.2",
+    "@types/trusted-types": "^2.0.7",
     "acorn": "^8.14.0",
     "babel-jest": "^30.0.4",
     "babel-loader": "^10.0.0",

package.json

@@ -1,11 +1,14 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "esnext",
     "lib": ["es5", "dom", "webworker", "es2022.error"],
+    "module": "nodenext",
+    "moduleResolution": "nodenext",
     "allowJs": true,
     "checkJs": true,
     "noEmit": true,
     "strict": true,
+    "types": ["@types/trusted-types", "webpack/module"],
     "skipDefaultLibCheck": true,
     "esModuleInterop": true
   },