Skip to content

[Feature]: Sort by running in "Crawl workflows" + faster pagination #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thsm-kb opened this issue Aug 21, 2024 · 6 comments · May be fixed by #2528
Open

[Feature]: Sort by running in "Crawl workflows" + faster pagination #2034

thsm-kb opened this issue Aug 21, 2024 · 6 comments · May be fixed by #2528
Assignees
Labels
back end Requires back end dev work enhancement New feature or request front end Requires front end dev work

Comments

@thsm-kb
Copy link

thsm-kb commented Aug 21, 2024

What change would you like to see?

It would be a great help to be able to sort so "running" was shown first.
It would also be more effective with the pagelist also above the results, so scrolling wasn't needed. Possibly with the option to use arrowkeys for next and previous page.

Context

Having +40 pages it is a lot of work finding the 4 running jobs to manually check up on them.

@tkrn
Copy link

tkrn commented Nov 1, 2024

Bump this up for better pagination, giving the user the ability to have 10, 25, 50 or 100 workflows per page would be terrific.

@Shrinks99
Copy link
Member

Shrinks99 commented Nov 18, 2024

Slightly confused... Running workflows should always be sorted to the top if sorting by "Latest Crawl".

EDIT: Nope! They aren't.

Noted on the page list scrolling. Thanks for feedback. Some thoughts on how to solve that are available in #747

@SuaYoo SuaYoo added front end Requires front end dev work back end Requires back end dev work labels Feb 10, 2025
@SuaYoo
Copy link
Member

SuaYoo commented Feb 10, 2025

We may want to support additional sorting by workflow state ordered as running states -> waiting states -> failed -> success -> never, since "Latest Crawl" doesn't address the case when a crawl starts while there's another workflow still running. And/or a state filter on workflows.

We'll look into general pagination improvements in #1944

@SuaYoo SuaYoo self-assigned this Feb 10, 2025
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Feb 10, 2025
@SuaYoo SuaYoo assigned tw4l and unassigned SuaYoo Mar 19, 2025
@tw4l
Copy link
Member

tw4l commented Mar 19, 2025

For now for the backend change to make is to ensure that running crawls are always floated to the top for "Latest Crawl" sort order.

We may look into additional changes to make but want to avoid having an opaque "Last Updated" type sort option with a complicated algorithm, as we had that before and removed it because users didn't understand the logic.

@tw4l tw4l moved this from Todo to Ready in Webrecorder Projects Mar 24, 2025
@SuaYoo SuaYoo marked this as a duplicate of #2413 Apr 1, 2025
@emma-sg emma-sg self-assigned this Apr 1, 2025
@ikreymer ikreymer moved this from Ready to Todo in Webrecorder Projects Apr 1, 2025
@emma-sg emma-sg moved this from Todo to Ready in Webrecorder Projects Apr 1, 2025
@emma-sg emma-sg linked a pull request Apr 1, 2025 that will close this issue
@emma-sg emma-sg moved this from Ready to Implementing in Webrecorder Projects Apr 1, 2025
@emma-sg
Copy link
Member

emma-sg commented Apr 1, 2025

Got started on this in #2528 — this'll add an option to show running crawls separately from the rest of the crawls, so far with a separate pagination if necessary for both groups. Once this is done I'll also work on getting pagination persisted in URLs (e.g. /orgs/emmas-local-org/workflows?page=14)!

@ikreymer
Copy link
Member

ikreymer commented Apr 1, 2025

Another option is to reuse the super admin interface we already have for all running crawls, and just make it available for a single org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end Requires back end dev work enhancement New feature or request front end Requires front end dev work
Projects
Status: Implementing
Development

Successfully merging a pull request may close this issue.

7 participants