-
-
Notifications
You must be signed in to change notification settings - Fork 51
Persist pagination state in url #2538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
was getting issues in dev where localizers were persisted in cache but garbage collected — not too sure why, but this fixes the issue, and there's only a few formatters so this shouldn't impact perf
Co-authored-by: sua yoo <sua@suayoo.com>
bd512c2
to
eb0472e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pagination looks great. I tested with workflows, archived items, collections, collection items, and browser profiles, going backwards and forwards in browser history.
Let's cherry pick eb0472e into a separate branch though, to keep the scope of this PR (and squashed commit) to pagination?
eb0472e
to
9ea55e9
Compare
Yep, makes sense. Moved it to #2538, and removed from this PR. |
Closes #1944
Changes
name
propertyManual testing