Skip to content

devex: Data grid component #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

devex: Data grid component #2561

wants to merge 31 commits into from

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Apr 23, 2025

WIP for #2497 and #2536

Changes

  • Adds new <btrix-data-grid> component
  • Refactors <btrix-usage-history-table> as proof of concept

Manual testing

First, run yarn to install new dependencies.

To test the new component in Storybook:

  1. Run yarn storybook
  2. Click "Data Table"
  3. Verify that the data table supports all current table functionality, and in addition:
  • Basic keyboard navigation and refocusing
  • Usage as form control, including validation

To test the usage history table migration:

  1. Run yarn start
  2. Log in as org admin
  3. Go to "Settings" -> "Billing"
  4. Regression test usage history table

Screenshots

Page Image/video
Storybook Screenshot 2025-04-29 at 3 31 07 PM

Base automatically changed from frontend-refactor-table-padding to main April 24, 2025 02:31
@SuaYoo SuaYoo force-pushed the frontend-data-grid-component branch from 93e6f34 to e5a0a75 Compare April 24, 2025 02:32
@SuaYoo SuaYoo mentioned this pull request Apr 22, 2025
3 tasks
@SuaYoo SuaYoo requested review from ikreymer, emma-sg and tw4l April 29, 2025 22:55
@SuaYoo SuaYoo marked this pull request as ready for review April 29, 2025 22:55
Co-authored-by: Emma Segal-Grossman <hi@emma.cafe>
@SuaYoo SuaYoo requested a review from emma-sg April 30, 2025 02:56
@SuaYoo
Copy link
Member Author

SuaYoo commented Apr 30, 2025

@emma-sg FYI added option to make number of rows being added configurable in 458b4ac

Screenshot 2025-04-30 at 10 32 54 AM

It was quick enough to add and not enabled by default, I figure we can tweak styling once we see it in a real-life use case.

@SuaYoo SuaYoo requested a review from emma-sg April 30, 2025 21:55
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Nice work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants