Skip to content

feat: Filter workflows by tag + update existing filter UI #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 8, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jul 1, 2025

Resolves #2660

Changes

  • Enables filtering workflow list by tag
  • Displays tags near workflow name in detail view
  • Adds <btrix-filter-chip> component
    • Migrates "schedule state", "only running", and "only mine" filters
    • Adds basic documentation to Storybook

Manual testing

  1. Log in
  2. Go to "Crawling"
  3. Click "Tags" in "Filter by" section. Verify org tags are displays
  4. Start typing a tag name. Verify tags are narrowed down to search
  5. Choose tags. Verify workflows are filtered to selected tags
  6. Regression test schedule, running, and mine filters

Screenshots

Page Image/video
Crawling Screenshot 2025-07-07 at 12 27 07 PM
Crawling Screenshot 2025-07-07 at 12 27 13 PM
Crawling Screenshot 2025-07-07 at 12 27 19 PM
Crawling Screenshot 2025-07-07 at 12 27 26 PM
Workflow detail Screenshot 2025-07-07 at 12 30 43 PM

Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, noticed one issue, it looks like enabling any filter also sets isCrawlRunning to false, which hides all running workflows

@emma-sg
Copy link
Member

emma-sg commented Jul 2, 2025

A bit out of scope for this PR, but it'd be really nice to see workflow counts per tag — @tw4l if you have a moment, how much work do you think this'd be on the backend? I think we'd have to construct a slightly more complicated query instead of just distinct

Edit: took a go at this myself in #2711

SuaYoo and others added 4 commits July 7, 2025 09:36
Co-authored-by: Emma Segal-Grossman <hi@emma.cafe>
Co-authored-by: Emma Segal-Grossman <hi@emma.cafe>
@SuaYoo
Copy link
Member Author

SuaYoo commented Jul 7, 2025

A bit out of scope for this PR, but it'd be really nice to see workflow counts per tag

Nice, yeah let's merge this after.

@SuaYoo SuaYoo marked this pull request as draft July 7, 2025 18:11
@ikreymer ikreymer marked this pull request as ready for review July 7, 2025 18:43
Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well for demo - i think should be good to merge!

@SuaYoo SuaYoo changed the title feat: Filter workflows by tag feat: Filter workflows by tag + update existing filter UI Jul 7, 2025
@SuaYoo SuaYoo requested a review from emma-sg July 7, 2025 19:28
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, looks good & functions well!

@ikreymer ikreymer merged commit 7a6b1d7 into main Jul 8, 2025
27 checks passed
@ikreymer ikreymer deleted the frontend-filter-workflows-by-tag branch July 8, 2025 00:11
@ikreymer ikreymer moved this to Done! in Webrecorder Projects Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

[Feature]: Filter crawl workflows by tag
3 participants