-
-
Notifications
You must be signed in to change notification settings - Fork 55
Remove workflows from GET profile endpoint + Add inUse flag #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workflows from GET profile endpoint + Add inUse flag #2703
Conversation
The frontend will fetch workflows separately via the paginated list endpoint, filtering by profile id, to speed up loading of profiles in the UI.
Temporarily solution, as we'll shortly want to add workflows back to this the profile detail using a separate paginated API endpoint.
…profile set exists fill inUse field on the profile
Added Do we actually want to list workflows on the profile detail, rather than add a new filter (following the refactoring in #2702) in the workflow section? |
I think we need to add this back to the list component delete as well (edit: done).
I think it's useful to be able to go to the workflow quickly from the profile - my take would be that we do both (edit: from Discord, solution is likely to add a link to the filtered workflow list from the profile detail) |
1de1b87
to
a4f7d3e
Compare
Deletion notifications are now fixed: ![]() Following #2702 , we discussed adding a workflow filter by profile and linking to that from the profile detail rather than creating yet another paginated workflow component. |
Great! One we have filtering by profiles (eg. #2708), the error could include a link to workflows with that profile. Otherwise, I think this is good for this issue! |
Connected to #2661