Allow searching by multiple tags & profiles with "and"/"or" options for tags #2717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`profileIdMatch` and `tagMatch` fields for match type (and vs or) rename internal params to use consistent naming, and use annotations for aliases, deprecations, descriptions, etc
crawl configs can only have one profile id, so using "and" to search for multiple profile ids is never going to return any results
emma-sg
changed the title
ikreymer
reviewed
Jul 11, 2025
ikreymer
reviewed
Jul 11, 2025
ikreymer
reviewed
Jul 11, 2025
|
Looks good overall, though I think we don't need the deprecation of 'profileid' as it was never released and just added. |
ikreymer
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2716
Closes #2715
Changes
profileIdfield that accepts multiple itemsprofileidfield that does not accept multiple itemstagMatchfield that accepts"or" | "and"Testing
Tested locally with
curl— all fields seem to work!Next Steps
Frontend PR is #2727