Skip to content

fix: set xml node background to white #5183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025
Merged

fix: set xml node background to white #5183

merged 1 commit into from
May 4, 2025

Conversation

JayaKrishnaNamburu
Copy link
Contributor

Description

fixes #5015
Added backgroundColor to white for XMLNode so the content is visible even when the GlobalRoot is set to something else.

Steps for reproduction

  • Create a demo project.
  • Create a XML with sitemap.xml
  • Now, switch back to the home page and set the backgroudnColor of the global root to some random colour.
  • Then, switch back to the sitemap page. Now, the contents are not visible as the background is inherited from the GlobalRoot. This fix will help in setting to white whenever a xml node is used.

Code Review

  • hi @kof, I need you to do
    • test it on preview

Before requesting a review

  • made a self-review

Before merging

  • tested locally and on preview environment (preview dev login: 0000)

@TrySound TrySound merged commit d3be082 into main May 4, 2025
17 checks passed
@TrySound TrySound deleted the fix/xml-bg branch May 4, 2025 14:33
@TrySound
Copy link
Member

TrySound commented May 4, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use white bg and padding on XML pages
2 participants