-
Notifications
You must be signed in to change notification settings - Fork 42
Maintenance v2.1.0 #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance v2.1.0 #443
Conversation
…holder. Mouse events now have to be explicitly allowed on the teleport control.
…eck for invisible layers.
…d most recent changes to examples in app-starter.
…no longer accessible $appConfig from plain javascript files.
Hi guys, it´s been a while but I finally had the time to test the recent Wegue version with a larger custom application. Most parts worked out fine instantly - a great job! - This PR fixes some mostly simple oversights. Regarding 128395b: This introduces some I have another branch setup with 2-3 simple layout related tweaks. These aren`t functional so I will post them seperately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fschmenger and thanks for your return on the latest changes and for this PR !
For sure, this was a lot of work and it is difficult to think about all use cases and verify all this. So this kind of returns are more than welcome, even more when coming from people who already know the product and used it quite a lot !
I think all this makes sense and is really interesting. I've just made some simple suggestions with missing semicolons which are purely for esthetics, nothing important there.
Just to give some information about some of your changes and keep a log somewhere:
- Vue-portal V3 was still used while migrating to Vue3 as the Teleport component was still flagged as experimental at that time.
- Good catch with Vuetify locales import. That's one thing that was migrated and worked at a certain time, but as Vuetify was updated a few times during the whole process, I'm pretty sure some other glitches may have appeared unfortunately.
- No problem at all to add back some
on
styles with Vuetify colors, that's a point on which upgrading was really a problem. Those styles still exists and are automatically assigned in some circumstances (as you certainly saw) but you can't reference them easily with auto-defined classes. Adding them back can be handy in some circumstances then.
For the rest, nice catches and additions, thanks again for the good work !
I already approved the PR, so merge at will, except if @chrismayer has some comments to add somewhere...
Cheers, Sébastien
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice catches, thank you @fschmenger !
Besides the minor findings by @sronveaux nothing to add. Just quickly tested the demo apps and everything seems to work as expected.
Co-authored-by: Sébastien Ronveaux <57899415+sronveaux@users.noreply.github.com>
Thanks for the reviews! |
This branch contains a couple of bugfixes, mostly related to the recent Vue3 migration. For details please see the commit messages.