-
Notifications
You must be signed in to change notification settings - Fork 45
Meta: override default issue class to display GitHub issue links #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OK - will fix then. |
karlcow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
There's a build failure on the other hand. |
|
|
|
We're slightly more correct now, but it's still not happy:
|
|
I think if you rebase this CI should be okay btw. Tab fixed it in 1623a6a so I could land the Simplified Chinese translation. |
|
This is still quite sad. @tabatkins - any ideas on workarounds for https://github.com/whatwg/compat/actions/runs/16502615772/job/46665027177? |
|
Rebase this against the current HEAD; these have been fixed. |
|
(In particular, remove the single quotes from the property names, that's making it an autolink rather than plain text.) |
|
@miketaylr if you look at "Files changed" I think it shows something went wrong with rebasing. I would recommend against using merge commits generally. |
|
Hm, I thought I did rebase correctly, but I guess not. |
|
@miketaylr it seems like you still made many unrelated changes. 🙁 |
|
Sorry, not my greatest git wrangling. |
Fixes #273
Preview | Diff