Skip to content

Conversation

@miketaylr
Copy link
Member

@miketaylr miketaylr commented May 31, 2025

Fixes #273


Preview | Diff

@miketaylr miketaylr requested a review from karlcow May 31, 2025 16:47
@miketaylr
Copy link
Member Author

Starting commit snapshot...
LINE 942:7: Saw an end tag </td>, but there were unclosed elements remaining before the nearest matching start tag (at 934:7).
Open tags: <table> at 926:1, <tbody> at 9[31](https://github.com/whatwg/compat/actions/runs/15365640619/job/43238184225?pr=274#step:5:32):3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 943:5: Saw an end tag </tr>, but there were unclosed elements remaining before the nearest matching start tag (at 9[32](https://github.com/whatwg/compat/actions/runs/15365640619/job/43238184225?pr=274#step:5:33):5).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 944:3: Saw an end tag </tbody>, but there were unclosed elements remaining before the nearest matching start tag (at 931:3).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 9[34](https://github.com/whatwg/compat/actions/runs/15365640619/job/43238184225?pr=274#step:5:35):7, <code> at 938:8
LINE 945:1: Saw an end tag </table>, but there were unclosed elements remaining before the nearest matching start tag (at 926:1).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 145: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup:
  '@media/-webkit-device-pixel-ratio'
LINE 182: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup:
  '@media/-webkit-transform-3d'
 ✘  Did not generate, due to errors exceeding the allowed error level.
make: *** [Makefile:23: deploy] Error 2
Error: Process completed with exit code 2.

OK - will fix then.

Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@karlcow
Copy link
Member

karlcow commented Jun 1, 2025

There's a build failure on the other hand.

Starting commit snapshot...
LINE 942:7: Saw an end tag </td>, but there were unclosed elements remaining before the nearest matching start tag (at 934:7).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 943:5: Saw an end tag </tr>, but there were unclosed elements remaining before the nearest matching start tag (at 932:5).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 944:3: Saw an end tag </tbody>, but there were unclosed elements remaining before the nearest matching start tag (at 931:3).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 945:1: Saw an end tag </table>, but there were unclosed elements remaining before the nearest matching start tag (at 926:1).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 145: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup:
  '@media/-webkit-device-pixel-ratio'
LINE 182: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup:
  '@media/-webkit-transform-3d'
 ✘  Did not generate, due to errors exceeding the allowed error level.
make: *** [Makefile:23: deploy] Error 2
Error: Process completed with exit code 2.

@miketaylr
Copy link
Member Author

miketaylr commented Jun 2, 2025

LINE 145: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup: '@media/-webkit-device-pixel-ratio' feels like an over-eager regular expression...

https://github.com/speced/bikeshed/blob/de38ee2b57af487f1c3f1bc5c47670dcf3384396/bikeshed/datablocks.py#L582-L642

@miketaylr
Copy link
Member Author

We're slightly more correct now, but it's still not happy:

LINE 145: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup: '-webkit-device-pixel-ratio'

@annevk
Copy link
Member

annevk commented Jul 24, 2025

I think if you rebase this CI should be okay btw. Tab fixed it in 1623a6a so I could land the Simplified Chinese translation.

@miketaylr
Copy link
Member Author

This is still quite sad. @tabatkins - any ideas on workarounds for https://github.com/whatwg/compat/actions/runs/16502615772/job/46665027177?

@tabatkins
Copy link
Contributor

Rebase this against the current HEAD; these have been fixed.

@tabatkins
Copy link
Contributor

(In particular, remove the single quotes from the property names, that's making it an autolink rather than plain text.)

@annevk
Copy link
Member

annevk commented Jul 24, 2025

@miketaylr if you look at "Files changed" I think it shows something went wrong with rebasing. I would recommend against using merge commits generally.

@miketaylr
Copy link
Member Author

Hm, I thought I did rebase correctly, but I guess not.

@miketaylr miketaylr merged commit c160ad0 into main Jul 24, 2025
2 checks passed
@miketaylr miketaylr deleted the issues/273/1 branch July 24, 2025 20:35
@annevk
Copy link
Member

annevk commented Jul 25, 2025

@miketaylr it seems like you still made many unrelated changes. 🙁

@miketaylr
Copy link
Member Author

Sorry, not my greatest git wrangling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Warning for keyword mappings is nonsensical. (probably just a typo)

5 participants