-
Notifications
You must be signed in to change notification settings - Fork 305
Add reference target to shadow root #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -6057,6 +6058,7 @@ interface ShadowRoot : DocumentFragment { | |||
readonly attribute boolean clonable; | |||
readonly attribute boolean serializable; | |||
readonly attribute Element host; | |||
attribute DOMString? referenceTarget; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not quite sure, if it is good to have this v1 API and then more complicated v2, or could we have just one API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or whether this API should look a bit different so that adding v2 would feel a bit less weird.
Just as an example, not proposing this... what if this was more like
attribute ReferenceTarget referenceTarget;
and then
interface ReferenceTarget {
attribute DOMString? default;
// v2 would add more attributes
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the sketch for v2? We should at least have an idea on what this transition will look like. Did someone write that out?
@@ -6092,6 +6094,9 @@ It is initially set to false.</p> | |||
<p><a for=/>Shadow roots</a> have an associated <dfn for=ShadowRoot>serializable</dfn> (a boolean). | |||
It is initially set to false.</p> | |||
|
|||
<p><a for=/>Shadow roots</a> have an associated <dfn export for=ShadowRoot>reference target</dfn>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing a type declaration.
@@ -6057,6 +6058,7 @@ interface ShadowRoot : DocumentFragment { | |||
readonly attribute boolean clonable; | |||
readonly attribute boolean serializable; | |||
readonly attribute Element host; | |||
attribute DOMString? referenceTarget; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the sketch for v2? We should at least have an idea on what this transition will look like. Did someone write that out?
Reference Target is a feature to enable using IDREF attributes such as
for
andaria-labelledby
to refer to elements inside a component's shadow DOM, while maintaining encapsulation of the internal details of the shadow DOM. The main goal of this feature is to enable ARIA to work across shadow root boundaries.In this change, add the
referenceTarget
property toShadowRoot
and add a definition ofreference target
that's exported for use in other specs.See the reference target explainer.
Preview | Diff