Skip to content

Commit 9146111

Browse files
committed
Update according review
1 parent 4c80708 commit 9146111

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- uses: actions/checkout@v2
1818
with:
1919
submodules: true
20-
- uses: actions/setup-node@v1
20+
- uses: actions/setup-node@v3
2121
with:
2222
node-version: 18
2323
- run: npm install

index.bs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -654,9 +654,8 @@ enum ReadableStreamType { "bytes", "owning" };
654654
<p>Can be set to "<dfn enum-value for="ReadableStreamType">owning</dfn>" to signal that the
655655
constructed {{ReadableStream}} will own chunks (via transfer or serialization) before enqueuing them.
656656
This ensures that enqueued chunks are not mutable by the source.
657-
Transferred or serialized chunks may have <dfn>dispose steps</dfn> which are executed if
658-
enqueued chunks are dequeued without being provided to the application, for instance when
659-
a {{ReadableStream}} is errored.
657+
Chunks may have <dfn export>dispose steps</dfn> which are executed if enqueued chunks are dequeued
658+
without being provided to the application, for instance when a {{ReadableStream}} is errored.
660659
</p>
661660

662661
<p>Setting any value other than "{{ReadableStreamType/bytes}}", "{{ReadableStreamType/owning}}"
@@ -6779,6 +6778,7 @@ mark=] is greater than zero.
67796778

67806779
1. If |stream|.[=ReadableStream/[[controller]]=] [=implements=]
67816780
{{ReadableStreamDefaultController}},
6781+
1. If |transferList| is null, set |transferList| to an [=list/is empty|empty=] list.
67826782
1. Perform ! [$ReadableStreamDefaultControllerEnqueue$](|stream|.[=ReadableStream/[[controller]]=],
67836783
|chunk|, |transferList|).
67846784
1. Otherwise,

reference-implementation/lib/ReadableStreamDefaultController-impl.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ exports.implementation = class ReadableStreamDefaultControllerImpl {
1818
}
1919

2020
enqueue(chunk, options) {
21-
const transferList = options ? options.transfer : [];
21+
const transferList = options.transfer;
2222
if (transferList.length && !this._isOwning) {
2323
throw new TypeError('The stream is not an owning stream and cannot make use of options');
2424
}

0 commit comments

Comments
 (0)