Update readme #12
Open
Update readme #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whiskerz007
requested changes
Feb 21, 2021
README.md
Outdated
| cd /config/scripts | ||
| curl -LO --silent https://github.com/whiskerz007/ubnt_get_wireguard/raw/master/get_wireguard.sh | ||
| chmod +x get_wireguard.sh | ||
| sudo curl -L --silent https://github.com/whiskerz007/ubnt_get_wireguard/raw/master/get_wireguard.sh -o /config/scripts/get_wireguard.sh && sudo chmod +x /config/scripts/get_wireguard.sh |
There was a problem hiding this comment.
I'd prefer to keep the commands separate. Copy and paste works just as well with one or three lines of commands.
There was a problem hiding this comment.
Changed it and add the you need to be root for installation
There was a problem hiding this comment.
Why does the user need to be set to root?
There was a problem hiding this comment.
At least on my USG the config/scripts directory has write access for root only:
drwxr-xr-x 4 root vyattacf 4096 Feb 3 22:50 scripts
There was a problem hiding this comment.
I can verify that the Unifi gateways do set the permissions to root:vyattacfg. Go ahead and include the commands with sudo and I'll merge the PR.
USG needs root to download files to /config/scripts folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While having a hard time finding the features/functions of the script I thought it would be good to have them on the first page of the repo.
Feel free to change the text