This repository was archived by the owner on Oct 9, 2022. It is now read-only.
Conversation
| ) | ||
| @settings(max_examples=500) | ||
| def test_advanced_theorems(ldlf_theorem, word, ldlf_formula_1, ldlf_formula_2): | ||
| """Test that the validity of theorems.""" |
Member
There was a problem hiding this comment.
is there a typo? "Test that the validity of theorems."
cipollone
approved these changes
May 21, 2020
Comment on lines
+80
to
+81
| "<a>({f1}) <-> ([!a]ff & <a>({f1}))", | ||
| "[a]({f1}) <-> (<!a>tt | [a]({f1}))", |
Collaborator
There was a problem hiding this comment.
I think the first of the two is always satisfied regardless of the formulae, because the same term appear twice.
Maybe the second is different. Could we change the two rightmost a with true to really use f1 as test?
Double check.
Collaborator
There was a problem hiding this comment.
No, I think I was wrong. Both have one direction of the implication which does not cancels out. -> [!a]ff for the first, and <- <!a>tt for the second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add some simple theorems in the tests. They are tested using Hypothesis to replace the placeholder with "every possible" formula (almost :-) )
Fixes
n/a
Types of changes
What types of changes does your code introduce to agents-tac?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.Further comments
n/a