Use dart-sass as sass compiler #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart-sass is the bleeding edge sass compiler and will always be the first to support new features. Since we want to stay update to date with exciting new sass features this is a natural move.
required to add a jest config variable to package.json to overcome this issue oddbird/true#156
lumninance uses float exponents which our current pow implmentation doens't support. Replaced with a powerfull math pow function provide by Tobias Bengfort. Write some more assertions specifient all variations of input values that a pow function can have.
renatodeleao
force-pushed
the
from-node-to-dart-sass
branch
from
0b57c3a to
bfb8e0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart-sass is the "reference implementation of sass", that means the first to support new features. Since we want to stay update to date with exciting new sass features this is a natural move.
This will allow us to migrate our codebase to the exciting new world of sass-modules
Related: #10 , #9