Skip to content

Isomap nnType: Method error #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FedeClaudi opened this issue Sep 14, 2022 · 3 comments
Open

Isomap nnType: Method error #30

FedeClaudi opened this issue Sep 14, 2022 · 3 comments
Assignees
Labels

Comments

@FedeClaudi
Copy link

Hey, thanks for this awesome package.

I'm trying to fit Isomap using nntype=KDTree from NearestNeighbors but I get a method error
image

The error line being NN = fit(nntype, X) here.

Any advice on how to get around this? Using brute force tree works but I'd like to find an easier solution.
Also, is there a way to pass an already fitted tree? I'd like to re-use the same tree across different analysis steps.

Thank you

@wildart
Copy link
Owner

wildart commented Sep 14, 2022

You cannot use directly KDTree. Here is the wrapper:

# Wrapper around NearestNeighbors functionality

@FedeClaudi
Copy link
Author

I see, thank you. Perhaps its worth adding a warning in the docs, I took them to mean that you can just use any tree type from nearest neighbours!

@wildart
Copy link
Owner

wildart commented Sep 15, 2022

Julia lets you carried away. I need to put a type check for AbstractNearestNeighbors there.

@wildart wildart added the bug label Sep 15, 2022
@wildart wildart self-assigned this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants