Add RemoteNamingPermission #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
remote-naming-permissiong
branch
2 times, most recently
from
f9408a2 to
51015b3
Compare
dmlloyd
reviewed
Feb 28, 2017
|
|
||
| try (MessageInputStream mis = message) { | ||
| if(!channel.getConnection().getLocalIdentity().implies(RemoteNamingPermission.getInstance())) { | ||
| throw Messages.log.noPermission(channel.getConnection().getLocalIdentity().getPrincipal().getName(), RemoteNamingPermission.getInstance()); |
There was a problem hiding this comment.
This should use writeExceptionResponse() to write the naming exception. Throwing before reading the inv ID means the response won't be correlated.
stuartwdouglas
force-pushed
the
remote-naming-permissiong
branch
from
51015b3 to
176c0bc
Compare
spyrkob
pushed a commit
to spyrkob/wildfly-naming-client
that referenced
this pull request
Nov 27, 2018
Add licence file and pom information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.