Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
package org.wildfly.naming.client;

import org.wildfly.security.permission.AbstractBooleanPermission;

/**
* Represents permission to invoke naming operations remotely
*
* @author Stuart Douglas
*/
public class RemoteNamingPermission extends AbstractBooleanPermission<RemoteNamingPermission> {

/**
* Construct a new instance.
*/
public RemoteNamingPermission() {
}

/**
* Construct a new instance.
*
* @param name ignored
*/
public RemoteNamingPermission(@SuppressWarnings("unused") final String name) {
}

/**
* Construct a new instance.
*
* @param name ignored
* @param actions ignored
*/
public RemoteNamingPermission(@SuppressWarnings("unused") final String name, @SuppressWarnings("unused") final String actions) {
}

private static final RemoteNamingPermission INSTANCE = new RemoteNamingPermission();

/**
* Get the instance of this class.
*
* @return the instance of this class
*/
public static RemoteNamingPermission getInstance() {
return INSTANCE;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import org.jboss.logging.annotations.Message;
import org.jboss.logging.annotations.MessageLogger;
import org.jboss.logging.annotations.Property;
import org.wildfly.naming.client.RemoteNamingPermission;
import org.wildfly.naming.client.RenameAcrossNamingProvidersException;
import org.wildfly.security.auth.AuthenticationException;

Expand Down Expand Up @@ -217,4 +218,7 @@ public interface Messages extends BasicLogger {

@Message(id = 48, value = "Failed to close one or more naming providers")
NamingException failedToCloseNamingProviders();

@Message(id = 49, value = "User %s does not have permission %s")
NoPermissionException noPermission(String name, RemoteNamingPermission instance);
}
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@
import org.jboss.remoting3.MessageInputStream;
import org.jboss.remoting3.MessageOutputStream;
import org.jboss.remoting3.util.MessageTracker;
import org.wildfly.naming.client.RemoteNamingPermission;
import org.wildfly.naming.client._private.Messages;
import org.xnio.IoUtils;

/**
* The server side of the remote naming transport protocol.
Expand Down Expand Up @@ -83,9 +85,15 @@ public void handleEnd(final Channel channel) {
}

public void handleMessage(final Channel channel, final MessageInputStream message) {

try (MessageInputStream mis = message) {
final byte messageId = mis.readByte();
final int id = readId(mis, version);
if(!channel.getConnection().getLocalIdentity().implies(RemoteNamingPermission.getInstance())) {
sendException(Messages.log.noPermission(channel.getConnection().getLocalIdentity().getPrincipal().getName(), RemoteNamingPermission.getInstance()), messageId, id);
IoUtils.safeClose(message);
return;
}
try {
switch (messageId) {
case Protocol.CMD_LOOKUP:
Expand Down