-
Notifications
You must be signed in to change notification settings - Fork 81
Prospero update operation to a specific version #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Prospero update operation to a specific version #706
Conversation
eb53ec9
to
1fc1ffd
Compare
Hi @spyrkob. Thanks for this. Please drop EAP7-2250 from this (e.g. the PR title etc) except if you want as an item in the "Related Issues" section. The general WildFly community has no visibility to the EAP7 project. |
1fc1ffd
to
5324a1b
Compare
thanks @bstansberry done. Should I create a WFLY Feature Request JIRA to track this as well? The main ticket right now is a Prospero GH ticket, so not sure how to handle this case in the RFE process. |
@spyrkob You only need a WFLY if you'll be making changes to the wildfly/wildfly code base. Otherwise filing one or not is up to the feature team. It won't show up in the release page without one (https://github.com/wildfly/wildfly/releases/tag/35.0.0.Final) or in the JIRA release notes for that JIRA version, but I will mention it in the release announcement because of the #705 tracker. We have features that come through WildFly Core that are the same; they only have a WFCORE so they don't show up on the main WF release page on Github. But I discuss them in the release announcement. |
5324a1b
to
ad4c7d4
Compare
# 'outside-perspective' roles, even if there is only one person in a role. | ||
feature-team: | ||
developer: Bartosz Spyrko-Smietanko | ||
sme: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spyrkob I can be the sme
for this feature if you're ok with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that'd be great, thank you!
- If the `--version` parameter is present, the `update perform` and `update prepare` operations use a manifest with this version to provision the server. | ||
- If the `--version` provided is lower than the current version, the user should be warned and asked to confirm the operation. | ||
- If the `--version` is used in conjunction with `--yes` flag, the downgrade confirmation is skipped. | ||
- If a server is subscribed to multiple channels, the customer has to provide versions of all the involved manifests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how would they do that:
- with multiple
--version
? - a
--versions <channel1>:<version>,<channel2>:<version>
? - or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either one works. Generally for Prospero arguments with multiple values, there is an option to either use a comma to separate the values, or specify the argument multiple times. So the two examples below are the same:
--version wildfly:28.0.0.Final
--version datasources:2.0.0.Final
--version wildfly:28.0.0.Final,datasources:2.0.0.Final
== Requirements | ||
|
||
==== Hard requirements: | ||
- Add a `--version` parameter to the update operation with values in format `<CHANNEL_NAME>:<VERSION>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<CHANNEL_NAME>
would be org.wildfly.channels:wildfly
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the name of the channel from the server configuration. For example my installation of WildFly has:
$ ./prospero channel list --dir wfly
Server /Users/spyrkob/workspaces/set/prospero/prospero/wfly is subscribed to following channels:
wildfly org.wildfly.channels:wildfly
$ cat wfly/.installation/installer-channels.yaml
---
schemaVersion: "2.0.0"
name: "wildfly"
repositories:
- id: "central"
url: "https://repo1.maven.org/maven2/"
- id: "jboss-public"
url: "https://repository.jboss.org/nexus/content/groups/public/"
- id: "mrrc"
url: "https://maven.repository.redhat.com/ga/"
manifest:
maven:
groupId: "org.wildfly.channels"
artifactId: "wildfly"
resolve-if-no-stream: "none"
I could run the update as
$ ./prospero update perform --dir wfly --version wildfly:28.0.0.Final
ad4c7d4
to
bacc3a0
Compare
I recorded an Asciinema to demonstrate this feature: https://asciinema.org/a/WMBleBkPDTLRyljlaavKkpptg |
@bstansberry can you please close this issue? I need to change the developer from Bartosz to me, so I created the #749 to suppress this current PR. @jmesnil are you ok to keep as SME? |
Issue: #705