Skip to content

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Mar 20, 2025

Issue: #705

@github-actions github-actions bot added invalid-categories The categories field in the proposal metadata is not valid stability-level/default "Default" stability-level labels Mar 20, 2025
@spyrkob spyrkob force-pushed the EAP7-2250_Prospero_update_to_version branch from eb53ec9 to 1fc1ffd Compare March 20, 2025 11:30
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed invalid-categories The categories field in the proposal metadata is not valid stability-level/default "Default" stability-level labels Mar 20, 2025
@bstansberry
Copy link
Contributor

Hi @spyrkob. Thanks for this. Please drop EAP7-2250 from this (e.g. the PR title etc) except if you want as an item in the "Related Issues" section.

The general WildFly community has no visibility to the EAP7 project.

@spyrkob spyrkob changed the title [EAP7-2250] Prospero update operation to a specific version Prospero update operation to a specific version Mar 21, 2025
@spyrkob spyrkob force-pushed the EAP7-2250_Prospero_update_to_version branch from 1fc1ffd to 5324a1b Compare March 21, 2025 12:12
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Mar 21, 2025
@spyrkob
Copy link
Contributor Author

spyrkob commented Mar 21, 2025

thanks @bstansberry done. Should I create a WFLY Feature Request JIRA to track this as well? The main ticket right now is a Prospero GH ticket, so not sure how to handle this case in the RFE process.

@bstansberry
Copy link
Contributor

@spyrkob You only need a WFLY if you'll be making changes to the wildfly/wildfly code base. Otherwise filing one or not is up to the feature team.

It won't show up in the release page without one (https://github.com/wildfly/wildfly/releases/tag/35.0.0.Final) or in the JIRA release notes for that JIRA version, but I will mention it in the release announcement because of the #705 tracker.

We have features that come through WildFly Core that are the same; they only have a WFCORE so they don't show up on the main WF release page on Github. But I discuss them in the release announcement.

@spyrkob spyrkob force-pushed the EAP7-2250_Prospero_update_to_version branch from 5324a1b to ad4c7d4 Compare March 27, 2025 12:28
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Mar 27, 2025
# 'outside-perspective' roles, even if there is only one person in a role.
feature-team:
developer: Bartosz Spyrko-Smietanko
sme:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spyrkob I can be the sme for this feature if you're ok with it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that'd be great, thank you!

- If the `--version` parameter is present, the `update perform` and `update prepare` operations use a manifest with this version to provision the server.
- If the `--version` provided is lower than the current version, the user should be warned and asked to confirm the operation.
- If the `--version` is used in conjunction with `--yes` flag, the downgrade confirmation is skipped.
- If a server is subscribed to multiple channels, the customer has to provide versions of all the involved manifests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how would they do that:

  • with multiple --version?
  • a --versions <channel1>:<version>,<channel2>:<version> ?
  • or something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either one works. Generally for Prospero arguments with multiple values, there is an option to either use a comma to separate the values, or specify the argument multiple times. So the two examples below are the same:

  --version wildfly:28.0.0.Final
  --version datasources:2.0.0.Final
--version wildfly:28.0.0.Final,datasources:2.0.0.Final

== Requirements

==== Hard requirements:
- Add a `--version` parameter to the update operation with values in format `<CHANNEL_NAME>:<VERSION>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<CHANNEL_NAME> would be org.wildfly.channels:wildfly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the name of the channel from the server configuration. For example my installation of WildFly has:

$ ./prospero channel list --dir wfly
Server /Users/spyrkob/workspaces/set/prospero/prospero/wfly is subscribed to following channels:

wildfly org.wildfly.channels:wildfly

$ cat wfly/.installation/installer-channels.yaml
---
schemaVersion: "2.0.0"
name: "wildfly"
repositories:
  - id: "central"
    url: "https://repo1.maven.org/maven2/"
  - id: "jboss-public"
    url: "https://repository.jboss.org/nexus/content/groups/public/"
  - id: "mrrc"
    url: "https://maven.repository.redhat.com/ga/"
manifest:
  maven:
    groupId: "org.wildfly.channels"
    artifactId: "wildfly"
resolve-if-no-stream: "none"

I could run the update as

$ ./prospero update perform --dir wfly --version wildfly:28.0.0.Final

@spyrkob spyrkob force-pushed the EAP7-2250_Prospero_update_to_version branch from ad4c7d4 to bacc3a0 Compare June 6, 2025 13:56
@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Jun 6, 2025
@spyrkob
Copy link
Contributor Author

spyrkob commented Jun 6, 2025

I recorded an Asciinema to demonstrate this feature: https://asciinema.org/a/WMBleBkPDTLRyljlaavKkpptg

@github-actions github-actions bot added stability-level/default "Default" stability-level and removed stability-level/default "Default" stability-level labels Jul 2, 2025
@pedro-hos
Copy link

@bstansberry can you please close this issue? I need to change the developer from Bartosz to me, so I created the #749 to suppress this current PR.

@jmesnil are you ok to keep as SME?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability-level/default "Default" stability-level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants