[WFLY-20384] - Restore the original behaviour of RoleMapping login module in the mapped role mapper #712
Conversation
github-actions
bot
added
the
invalid-categories
pedro-hos
force-pushed
the
WFLY-20384
branch
2 times, most recently
from
3294b3e to
769a4f3
Compare
github-actions
bot
added
stability-level/community
| === Changed requirements | ||
| Update the schema n order to add the new `properties-role-mapper` configuration. | ||
|
|
||
| === Non-Requirements |
There was a problem hiding this comment.
IIUIC, the original login module is able to load also property files from deployments: https://docs.redhat.com/en/documentation/red_hat_jboss_enterprise_application_platform/7.4/html-single/login_module_reference/index#rolemapping_login_module I assume such functionality is not planned.
There was a problem hiding this comment.
No managed components should be loading from deployed content.
There was a problem hiding this comment.
Also, the original module provides replaceRole option. Also out of the scope?
There was a problem hiding this comment.
@OndrejKotek I think that we can add this option as well, there are other mappers which already have this implemented. What do you think @darranl ?
| === Future Work | ||
| N/A | ||
|
|
||
| == Backwards Compatibility |
There was a problem hiding this comment.
Is it possible to use a file for the original login module directly without changes in the new mapper?
There was a problem hiding this comment.
I am sorry, I didn't got your question.
There was a problem hiding this comment.
I think the Backward Compatibility section should discuss how migrate from the original login module to the new Elytron based/integrated solution. The configuration is completely different and there is not much to be compatible (replaceRole option?), the data/properties file used by the configuration should be ideally usable as is without modifications. My question/suggestion is to write here an assurance that the properties file can be used without any changes when migrating from the original login module to Elytron.
github-actions
bot
added
stability-level/community
…dule in the mapped role mapper ading feature team
github-actions
bot
added
stability-level/community
Issue: #711
Jira: WFLY-20384