-
Notifications
You must be signed in to change notification settings - Fork 81
[#740] Support stability levels in Prospero #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have only few suggestions to change in the text.
* A prospero distribution can be switched to a different stability level using a `--stability` command argument. | ||
** The prospero distribution should define a minimum allowed stability level. | ||
** This argument should only be available on `community` or below stability levels. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to add an example of those CLI commands and messages that the user will see when they are not able to run the CLI command, as the first and second reqeuirements describe.
`JBoss-Product-Stability` defines the default stability that the distribution is running at when used without `--stability` flag | ||
|
||
`JBoss-Product-Minimal-Stability` defines the lowest stability level that the distribution is allowed to be switched to using `--stability` flag. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a minor change, but, WDYT to add the properties under bullet points? In my option is more clear to read. Like:
The stability level of Prospero distribution will be dictated by two properties added to the `MANIFEST.MF` or `prospero-common.jar` , `JBoss-Product-Stability` and `JBoss-Product-Minimal-Stability`:
* `JBoss-Product-Stability` defines the default stability that the distribution is running at when used without `--stability` flag
* `JBoss-Product-Minimal-Stability` defines the lowest stability level that the distribution is allowed to be switched to using `--stability` flag.
Fixes: #740