Skip to content

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Jun 24, 2025

Fixes: #740

@github-actions github-actions bot added the stability-level/community "Community" stability level label Jun 24, 2025
@github-actions github-actions bot added stability-level/community "Community" stability level and removed stability-level/community "Community" stability level labels Jul 1, 2025
@github-actions github-actions bot added stability-level/community "Community" stability level and removed stability-level/community "Community" stability level labels Jul 3, 2025
Copy link

@pedro-hos pedro-hos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have only few suggestions to change in the text.

* A prospero distribution can be switched to a different stability level using a `--stability` command argument.
** The prospero distribution should define a minimum allowed stability level.
** This argument should only be available on `community` or below stability levels.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to add an example of those CLI commands and messages that the user will see when they are not able to run the CLI command, as the first and second reqeuirements describe.

`JBoss-Product-Stability` defines the default stability that the distribution is running at when used without `--stability` flag

`JBoss-Product-Minimal-Stability` defines the lowest stability level that the distribution is allowed to be switched to using `--stability` flag.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a minor change, but, WDYT to add the properties under bullet points? In my option is more clear to read. Like:

The stability level of Prospero distribution will be dictated by two properties added to the `MANIFEST.MF` or `prospero-common.jar` , `JBoss-Product-Stability` and `JBoss-Product-Minimal-Stability`:

* `JBoss-Product-Stability` defines the default stability that the distribution is running at when used without `--stability` flag
* `JBoss-Product-Minimal-Stability` defines the lowest stability level that the distribution is allowed to be switched to using `--stability` flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability-level/community "Community" stability level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stability levels in Prospero
2 participants