WFTC-144: wildfly-transaction-client depends on the org.wildfly.secur…

[theashiot]

…ity:wildfly-elytron shaded artifact

https://issues.redhat.com/browse/WFTC-144

[emmartins]

Good news, I am bit surprised it turned out that the client doesn't directly need the elytron dependency

[emmartins]

The fails seem unrelated

[tadamski]

@theashiot thanks for the suggested fix, but unfortunately I cannot merge it. Some of Elytron classes, while not needed to compile, may be needed in runtime. To my knowledge, Elytron team is working on a fix in which only subset of those dependencies will be added.

[emmartins]

@tadamski there are no compile dependencies, and the tests seems to indicate there is no runtime dependency either.

[emmartins]

If you really want to keep a dependency to Elytron we should then replace the shaded jar with all elytron artifacts. Continuing with the shaded jar at this point doesn't sound an option and we should fix this asap.

[tadamski]

@emmartins @theashiot hmm, I am pretty certain that I tried to remove it some time ago but it was declined by Elytron team. @fjuma @darranl can this depenency be removed or it is something blocking us from doing so?

[darranl]

I had a chat with @theashiot last week, he is working on an alternative dependency that can be used instead of the shaded jar to achieve the same effect without the additional shaded content.

[emmartins]

@darranl I understand such move elsewhere, but here the question is why do we need such dependency at all. I don't see any compile or runtime dependency so IMHO we should just drop it.

[darranl]

All clients need WildFly Elytron as a runtime dependency otherwise JBoss Remoting will not be able to operate correctly.

[emmartins]

@darranl ok, thanks for clarifying that.