Hi @willynilly,
As discussed previously, I've setup the action on this repo, to test it. @girgink did the first PR, which triggered the action.
The information from the bot is in principle quite useful. And since this PR is quite straight forward, I seems fine. But I can imagine a scenario where, if I had any feedback for @girgink, the comments from the bot would kind of get on the way, as they are not part of the discussion in this PR.
I think the workflow would work better if the bot opens a new PR saying something along the lines: "Hey, @girgink contributed to this project through PR SS-NES/ss-nes.github.io#5, but he is not mentioned in the CFF. Give him credit by adding these lines to your CFF file".
What do you think? Does that make sense to you?
Hi @willynilly,
As discussed previously, I've setup the action on this repo, to test it. @girgink did the first PR, which triggered the action.
The information from the bot is in principle quite useful. And since this PR is quite straight forward, I seems fine. But I can imagine a scenario where, if I had any feedback for @girgink, the comments from the bot would kind of get on the way, as they are not part of the discussion in this PR.
I think the workflow would work better if the bot opens a new PR saying something along the lines: "Hey, @girgink contributed to this project through PR SS-NES/ss-nes.github.io#5, but he is not mentioned in the CFF. Give him credit by adding these lines to your CFF file".
What do you think? Does that make sense to you?