Fixes #7 #11
Merged
Fixes #7 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have pushed one additional change to this PR, instead of waiting for the 'add' event to fire, the popup is immediately bound to the feature. This allows the KML popups to work in conjunction with markercluster, when combined with the fix from: Leaflet/Leaflet.markercluster#970 I can't see any side effects of binding this early and I think overall it's probably helpful for any kind of external introspection of the KML layer before adding it to maps. Hopefully that's okay. |
|
Seems ok to me. Thank you! closes #7 |
|
Thank you for reviewing this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.