Skip to content

Conversation

rohith1222004
Copy link

Closes #56

Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please update README.md as well
  2. make it configurable

Submit
</button>
</div>
:null
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply use &&

Comment on lines +463 to +466
<div style={{display:'flex', justifyContent: 'space-between'}}>
{
!endQuiz?
<div style={{ display: 'flex',marginRight:'auto'}}>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use inline styles

<div style={{ display: 'flex',marginRight:'auto'}}>
<button
onClick={() => {submitQuiz()}}
style={{ display: 'flex', justifyContent: 'center', backgroundColor: 'green',color:'white' }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use inline styles

Comment on lines +371 to +375
const submitQuiz = () => {
setIsRunning(false);
setEndQuiz(true);
getUnansweredQuestions();
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code is same as handleTimeUp. don't duplicate it. revise the function and use for both case.

@Julix91
Copy link

Julix91 commented Oct 26, 2024

@rohith1222004 are you still interested in finishing this? Can you include a screenshot like #56 (comment) in the PR as well?

And if you could make the submit early button configurable: optional (off by default, set some kind of flag to turn it on) and so the caller can decide what to call the submit early button. "Quit" or "Exit" or whatever, depending on the context.

Also style wise it should probably look the same as the existing buttons, just copy the relevant classes I'm guessing.

Let me know if you need any help with the suggestions.

@obiora198
Copy link

@rohith1222004 I installed your branch and the submit button is not showing, apart from the Core.js file did you modify any other file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can i quit a quiz and still get result summary?
4 participants