Skip to content

Implemented submit-feature #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Implemented submit-feature #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/lib/Core.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,11 @@ function Core({
formatTime(seconds)
}${seconds}`;
};

const submitQuiz = () => {
setIsRunning(false);
setEndQuiz(true);
getUnansweredQuestions();
}
Comment on lines +371 to +375
Copy link
Owner

@wingkwong wingkwong Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code is same as handleTimeUp. don't duplicate it. revise the function and use for both case.

const handleTimeUp = () => {
setIsRunning(false);
setEndQuiz(true);
Expand Down Expand Up @@ -456,6 +460,21 @@ function Core({
/>
</div>
{activeQuestion && renderAnswers(activeQuestion, buttons)}
<div style={{display:'flex', justifyContent: 'space-between'}}>
{
!endQuiz?
<div style={{ display: 'flex',marginRight:'auto'}}>
Comment on lines +463 to +466
Copy link
Owner

@wingkwong wingkwong Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use inline styles

<button
onClick={() => {submitQuiz()}}
style={{ display: 'flex', justifyContent: 'center', backgroundColor: 'green',color:'white' }}
Copy link
Owner

@wingkwong wingkwong Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use inline styles

className="quitQuizBtn btn"
type="button"
>
Submit
</button>
</div>
:null
Copy link
Owner

@wingkwong wingkwong Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply use &&

}
{(showNextQuestionButton || allowNavigation) && (
<div className="questionBtnContainer">
{allowNavigation && currentQuestionIndex > 0 && (
Expand All @@ -477,6 +496,7 @@ function Core({
</button>
</div>
)}
</div>
</>
) : (
<span className="timerPauseScreen dark:text-white text-black">
Expand Down