Uses pattern matching cast instead of unsafe PlayerEntity cast to ensure the game does not crash due to unsafe cast #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sp-forest#63 which I also encountered due to Archon Boss Inigo's Beam attack being marked as a player attack (so not Conjuring's fault but still safer to do a pattern matching cast instead)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the commit message, this is not really the fault of Conjuring as it does check DamageSource#getName to ensure it is a damage source involving players but with a really small change you can ensure Conjuring doesn't result in a crash in the event of mislabeled DamageSources
Fixes #63