The Lost Castle (TLC) compat

[TheGoldenKnight]

TLC has a crutial villager trade that dissapears when Numesmatic Overhaul is enabled.
The villager trade of cartographer map to the castle from TLC is removed with Numesmatic. This is an issue for making my modpack. I do not want to have to choose one over the other since they both are pretty awesome mods. I did extensive testing to find what mod out of many other mods before writing this.

[Noaaan]

In theory this should be doable. With your modpack you could simply ship a datapack which adds a trade to the Cartographer with the map, as we do support selling maps this way.

Note that we do support trades added via vanilla and Fabric API. Looking at the code TLC does do this, so it is strange that it does not work 🤔

[Noaaan]

Looking further into the issue it seems that Numismatic Overhaul's automatic trade converter only properly supports adding trades via Fabric API for modded villagers. You are still able to add trades to vanilla villagers via data though, as demonstrated with this datapack: TLC Compat NO.zip

I am still unsure how to improve on this system, as it is somewhat complicated. In the future this might be something to revisit

[Noaaan]

Note that TLC could ship this data and it would work just fine. This is preferable, since we wrap the vanilla map generator to create a map, and therefore with TLC it lacks a translation key as shown below.