Skip to content

propagate props to children components in connectWithShell #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

propagate props to children components in connectWithShell #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd1e36
propagate props to children components in connectWithShell
Sep 29, 2020
acd8be2
Merge branch 'master' into fix-conectWithshell-children-wrapping
Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/connectWithShell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,23 @@ function wrapWithShellContext<S, OP, SP, DP>(
}
}

const ChildWithContext: React.FunctionComponent<any> = props => {
return (
<ShellContext.Provider value={props.originalShell}>
<>
{React.Children.map(props.children, child =>
child ? React.cloneElement(child, _.omit(props, ['children', 'originalShell'])) : child
)}
</>
</ShellContext.Provider>
)
}

const wrapChildrenIfNeeded = (props: WithChildren<OP>, originalShell: Shell): WithChildren<OP> =>
props.children
? {
...props,
children: <ShellContext.Provider value={originalShell}>{props.children}</ShellContext.Provider>
children: <ChildWithContext originalShell={originalShell}>{props.children}</ChildWithContext>
}
: props

Expand Down