TestKit| createAppHostAndWaitForLoading: filtered packages according to pacts #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nircwix
reviewed
Apr 28, 2025
|
|
||
| const filteredPackagesByPacts = (packages: EntryPointOrPackage[], pacts: PactAPIBase[]) => { | ||
| const pactAPINameSet = new Set(pacts.map(pact => pact.getAPIKey().name)) | ||
| const flatPackages: EntryPoint[] = _.flatten(packages) |
Contributor
There was a problem hiding this comment.
can you rename to flatEntryPoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REP reference
when create an
appHostin the testkit, passing a mockpactof an API requires also adding its package to theignoredPackages, otherwise we get an errorExtension slot with key '${slotName}' already exists.therefore, when we add a
pactwe also need to add the package to ignore (duplication, prone to errors)this PR changes the
createAppHostAndWaitForLoadingfunction to filter out the packages that their apis is being mocked.