Skip to content

Conversation

@retyui
Copy link
Contributor

@retyui retyui commented Dec 3, 2024

Issue: #7821, #7943

Script was tested on: 0.72, 0.73, 0.74, 0.75, 0.76

To test:

npx @react-native-community/cli init Rn74 --version 0.74
cd Rn74
yarn add react-native-navigation@https://github.com/retyui/react-native-navigation.git#feat/retyui/add-kotlin-autolinker
npx rnn-link
Screenshot 2024-12-03 at 13 41 49

@retyui retyui force-pushed the feat/retyui/add-kotlin-autolinker branch 2 times, most recently from a1c0357 to d924541 Compare December 3, 2024 12:40
@retyui retyui mentioned this pull request Dec 3, 2024
3 tasks
@retyui retyui marked this pull request as ready for review December 3, 2024 12:57
@retyui retyui force-pushed the feat/retyui/add-kotlin-autolinker branch 2 times, most recently from 544ea7f to e812b19 Compare December 3, 2024 13:34
@gosha212
Copy link
Contributor

gosha212 commented Dec 4, 2024

Great work @retyui. Can you add tests to the new use cases please? We will make the full review latter

@retyui retyui force-pushed the feat/retyui/add-kotlin-autolinker branch from e812b19 to 9746326 Compare December 4, 2024 10:31
@retyui
Copy link
Contributor Author

retyui commented Dec 4, 2024

@gosha212 I added test cases for new Kotlin files in RN 0.73, and happy that old tests cases wasn't affected (no breaking changes)

@erennyuksell
Copy link

This problem persists even in the latest version. May I know why it has not been merged?

@retyui
Copy link
Contributor Author

retyui commented Mar 3, 2025

@gosha212 can you review it please ?

@retyui retyui force-pushed the feat/retyui/add-kotlin-autolinker branch from 9746326 to 843ac63 Compare March 3, 2025 10:38
@gosha212
Copy link
Contributor

gosha212 commented Mar 3, 2025

@retyui we are working on new arch support on rn76-78. Once it done we will review this fix.

@gosha212
Copy link
Contributor

@retyui thanks for the contribution and inspiration. I'm closing the PR. You are welcome to review the updated one:
#8044

@gosha212 gosha212 closed this Jun 10, 2025
@retyui retyui deleted the feat/retyui/add-kotlin-autolinker branch June 10, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants