issue #255 - adding new code tables 4.120, 4.121. 4.122 #304

amilan17 · 2025-01-23T13:31:26Z

#255

…or-verification-scores

GRIB2_CodeFlag_4_120_CodeTable_en.csv

GRIB2_CodeFlag_4_122_CodeTable_en.csv

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv

amilan17

@sebvi please look at the suggested text for the octets for template 4.146.

…or-verification-scores

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv

GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv

GRIB2_Template_4_148_ProductDefinitionTemplate_en.csv

GRIB2_Template_4_149_ProductDefinitionTemplate_en.csv

amilan17

@sebvi please see specific questions below, mostly for the rows that are "notes"

GRIB2_Template_4_149_ProductDefinitionTemplate_en.csv

GRIB2_Template_4_150_ProductDefinitionTemplate_en.csv

GRIB2_Template_4_151_ProductDefinitionTemplate_en.csv

…or-verification-scores

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv

GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv

GRIB2_Template_4_148_ProductDefinitionTemplate_en.csv

amilan17

@sebvi see suggestions

Fix typo in line 25 (missing row) and 55

…or-verification-scores

* issue #255 - adding new code tables 4.120, 34.121. 4.122 * #issue 255 adding the templates * fix CSV 4.120, * change to lower case * Renumber templates * Update GRIB2_CodeFlag_4_120_CodeTable_en.csv * Fix reference to code table 4.122 * Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_148_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_149_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_150_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_151_ProductDefinitionTemplate_en.csv * minor edits for consistency * Update GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv * issue #255 fixing typos with loops and add end of sequences * Update GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv Fix typo in line 25 (missing row) and 55 * update 4.120 --------- Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com>

* issue #282 adding entries in code table 4.2.2.4 and 4.238 (#298) * issue #282 adding entries in code table 4.2.2.4 and 4.238 * Update GRIB2_CodeFlag_4_2_2_4_CodeTable_en.csv --------- Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> * issue #283 (#297) * issue #283 adding entries in code table 4.2.10.0 and 4.2.10.2 with corresponding notes * Update GRIB2_CodeFlag_4_2_10_2_CodeTable_en.csv * add note New wave and ocean parameters in Code Table 4.2 discipline 10 categories 0 and 2 #283 --------- Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> * issue #287 adding new radar entried in code table 4.2.0.15 and creating new code table 4.106 (#295) #287 Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> * 279 code table 42 0 7 add new codes for storm severity index ssi (#302) #279 --------- Co-authored-by: Sandrine Edouard <sed000@hpcr5-in1.science.gc.ca> * issue #286 adding new code table entries (#293) * issue #286 adding new code table entries * Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv * #issue 286 moving downward short-wave radiation flux from entry 30 to 31 in Code table 4.2.10.2 * Update GRIB2_CodeFlag_4_2_2_4_CodeTable_en.csv --------- Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> * #issue 292 adding new entries in Code Table 4.2 and 4.5 (#303) #292 Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>292 * issue #281 adding templates code tablesentries, code table and notes for the random fields proposal (#299) #281 Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> * 285 new categories for hazard indices in discipline 20 code table 41 and 42 and new code table 4253 (#294) * issue #286 adding new category for hazards in discipline 20 and associated Code table 4.2 entries * issue #285 adding new Code Table 4.253 * #issue 285: editorial change in code table 4.2.20.4 and 4.2.20.5 to remove capital letters, modified code table 4.253 * Update GRIB2_CodeFlag_4_2_20_4_CodeTable_en.csv * fix csv --------- Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> * Update GRIB2_CodeFlag_0_0_CodeTable_en.csv fix spelling * Apply suggestions from code review editorial, notes * minor editorial * editorial * Update GRIB2_CodeFlag_4_0_CodeTable_en.csv * Apply suggestions from code review * Apply suggestions from code review * issue #280 adding templates 4.137 to 4.142 and update of code table 4.0 (#300) * issue #280 adding templates 4.137 to 4.142 and update of code table 4.0 * Update GRIB2_Template_4_137_ProductDefinitionTemplate_en.csv Some incorrect OctetCount entries corrected * Update GRIB2_Template_4_138_ProductDefinitionTemplate_en.csv Delete OctetCount = 12 for the "next innermost step of processing", as it is not a 12 byte long entry. * Update GRIB2_Template_4_141_ProductDefinitionTemplate_en.csv Add OctetCount entries * Update GRIB2_Template_4_137_ProductDefinitionTemplate_en.csv Correct typo in month of model .. * minor editorial --------- Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com> * fix caps * issue #284 (#296) * issue #284 adding 2 new templates and corresponding entries in code table 4.0 * #issue 284 changing number of octets to 4 for peturbation number and number of forecasts in ensemble in template 4.145 * Update GRIB2_Template_4_144_ProductDefinitionTemplate_en.csv Delete OctetCount=12 in line number 38 for "next immermost step.." * Update GRIB2_Template_4_145_ProductDefinitionTemplate_en.csv Correct octet count for perturbation number and number of forecatsin ensemble and delete OctetCount=12 in line number 41 * Update GRIB2_Template_4_145_ProductDefinitionTemplate_en.csv Correct codeTable entry (4.10) for statistical process used * Update GRIB2_Template_4_144_ProductDefinitionTemplate_en.csv Correct codeTable entry (4.10) for statistical process used --------- Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com> * issue #255 - adding new code tables 4.120, 4.121. 4.122 (#304) * issue #255 - adding new code tables 4.120, 34.121. 4.122 * #issue 255 adding the templates * fix CSV 4.120, * change to lower case * Renumber templates * Update GRIB2_CodeFlag_4_120_CodeTable_en.csv * Fix reference to code table 4.122 * Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_148_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_149_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_150_ProductDefinitionTemplate_en.csv * Update GRIB2_Template_4_151_ProductDefinitionTemplate_en.csv * minor edits for consistency * Update GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv * issue #255 fixing typos with loops and add end of sequences * Update GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv Fix typo in line 25 (missing row) and 55 * update 4.120 --------- Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com> * Apply suggestions from code review * Update GRIB2_CodeFlag_4_120_CodeTable_en.csv * update note ids * xml,txt files --------- Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int> Co-authored-by: Sandrine Edouard <sed000@hpcr5-in1.science.gc.ca> Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com> Co-authored-by: Enrico Fucile <efucile@wmo.int>

issue #255 - adding new code tables 4.120, 34.121. 4.122

65a7391

amilan17 linked an issue Jan 23, 2025 that may be closed by this pull request

New section 4 templates and tables for verification scores #255

Closed

amilan17 marked this pull request as draft January 23, 2025 13:31

amilan17 changed the base branch from master to FT2025-1 January 23, 2025 13:31

sebvi and others added 2 commits January 27, 2025 16:36

#issue 255 adding the templates

58a4fe7

Merge branch 'FT2025-1' into 255-new-section-4-templates-and-tables-f…

498f0dc

…or-verification-scores

amilan17 marked this pull request as ready for review January 28, 2025 14:39

amilan17 added 3 commits January 28, 2025 15:46

fix CSV 4.120,

bde3fd7

change to lower case

0900c96

Renumber templates

5387bce

amilan17 commented Jan 29, 2025

View reviewed changes

GRIB2_CodeFlag_4_120_CodeTable_en.csv Outdated Show resolved Hide resolved

Update GRIB2_CodeFlag_4_120_CodeTable_en.csv

f0f635e

amilan17 commented Jan 29, 2025

View reviewed changes

GRIB2_CodeFlag_4_120_CodeTable_en.csv Outdated Show resolved Hide resolved

amilan17 commented Jan 29, 2025

View reviewed changes

GRIB2_CodeFlag_4_122_CodeTable_en.csv Show resolved Hide resolved

Fix reference to code table 4.122

53a9e77

amilan17 commented Jan 29, 2025

View reviewed changes

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Jan 29, 2025

View reviewed changes

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Jan 29, 2025

View reviewed changes

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 added 3 commits January 29, 2025 15:53

Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv

af310e2

Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv

65ecf67

Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv

ad1f647

amilan17 marked this pull request as draft January 29, 2025 14:59

amilan17 commented Jan 29, 2025

View reviewed changes

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Jan 29, 2025

View reviewed changes

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Jan 29, 2025

View reviewed changes

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Jan 29, 2025

View reviewed changes

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Jan 29, 2025

View reviewed changes

amilan17 and others added 3 commits January 30, 2025 14:39

Merge branch 'FT2025-1' into 255-new-section-4-templates-and-tables-f…

d489463

…or-verification-scores

Update GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv

c167844

Update GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv

79a4b55

minor edits for consistency

c81659d

amilan17 changed the title ~~issue #255 - adding new code tables 4.120, 34.121. 4.122~~ issue #255 - adding new code tables 4.120, 4.121. 4.122 Feb 6, 2025

amilan17 commented Feb 6, 2025

View reviewed changes

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Feb 6, 2025

View reviewed changes

GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Feb 6, 2025

View reviewed changes

GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv Show resolved Hide resolved

amilan17 commented Feb 6, 2025

View reviewed changes

GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Feb 6, 2025

View reviewed changes

GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

Update GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv

be6efa6

amilan17 commented Feb 6, 2025

View reviewed changes

GRIB2_Template_4_148_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Feb 6, 2025

View reviewed changes

GRIB2_Template_4_149_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Feb 6, 2025

View reviewed changes

GRIB2_Template_4_149_ProductDefinitionTemplate_en.csv Show resolved Hide resolved

amilan17 commented Feb 6, 2025

View reviewed changes

Merge branch 'FT2025-1' into 255-new-section-4-templates-and-tables-f…

1c198e2

…or-verification-scores

amilan17 commented Feb 7, 2025

View reviewed changes

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Feb 7, 2025

View reviewed changes

GRIB2_Template_4_146_ProductDefinitionTemplate_en.csv Show resolved Hide resolved

amilan17 commented Feb 7, 2025

View reviewed changes

GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Feb 7, 2025

View reviewed changes

GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Feb 7, 2025

View reviewed changes

GRIB2_Template_4_148_ProductDefinitionTemplate_en.csv Outdated Show resolved Hide resolved

amilan17 commented Feb 7, 2025

View reviewed changes

GRIB2_Template_4_148_ProductDefinitionTemplate_en.csv Show resolved Hide resolved

amilan17 commented Feb 7, 2025

View reviewed changes

sebvi and others added 5 commits February 11, 2025 14:16

issue #255 fixing typos with loops and add end of sequences

37d645e

Update GRIB2_Template_4_147_ProductDefinitionTemplate_en.csv

8a9bee2

Fix typo in line 25 (missing row) and 55

Merge branch 'FT2025-1' into 255-new-section-4-templates-and-tables-f…

fc1c842

…or-verification-scores

update 4.120

f78d945

Merge branch 'FT2025-1' into 255-new-section-4-templates-and-tables-f…

a7abe75

…or-verification-scores

amilan17 marked this pull request as ready for review February 13, 2025 14:29

amilan17 merged commit 58e91b9 into FT2025-1 Feb 13, 2025
1 check failed

amilan17 deleted the 255-new-section-4-templates-and-tables-for-verification-scores branch April 3, 2025 14:53

issue #255 - adding new code tables 4.120, 4.121. 4.122 #304

issue #255 - adding new code tables 4.120, 4.121. 4.122 #304

Uh oh!

Conversation

amilan17 commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amilan17 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amilan17 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amilan17 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amilan17 commented Jan 23, 2025 •

edited

Loading

amilan17 left a comment •

edited

Loading