go-1.24: fix go main version not semver compatible

Fix +incompatible+dirty build metadata to be semver compatible.

Author: xnox

go-1.24.yaml

@@ -1,7 +1,7 @@
 package:
   name: go-1.24
   version: "1.24.0"
-  epoch: 0
+  epoch: 1
   description: "the Go programming language"
   copyright:
     - license: BSD-3-Clause
@@ -41,6 +41,7 @@ pipeline:
       patches: |
         cmd-go-always-emit-ldflags-version-information.patch
         change-default-telemetry-from-local-to-off.patch
+        go-fix-incompatible-dirty-build-metadata-to-be-SemVe.patch
 
   - runs: |
       cd src

go-1.24/go-fix-incompatible-dirty-build-metadata-to-be-SemVe.patch

@@ -0,0 +1,70 @@
+From ee66f3c8fd27506c789810fff86f09880d0354ad Mon Sep 17 00:00:00 2001
+From: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
+Date: Tue, 19 Jul 2022 11:07:00 -0400
+Subject: [PATCH] go: fix +incompatible+dirty build metadata to be SemVer
+ compatible
+
+Change "+incompatible+dirty" version to be "+incompatible.dirty" such
+that it is SemVer spec compatible.
+
+Struggling to add test case for a locally generated module that will
+create +incompatible version.
+
+See:
+- https://github.com/golang/go/issues/71971
+- https://github.com/golang/go/issues/71969
+- https://github.com/golang/go/issues/71970
+- https://github.com/anchore/grype/issues/2482
+- https://semver.org/#spec-item-10
+
+Change-Id: I714ffb3f1ad88c793656c3652367db34739a2144
+---
+ src/cmd/go/internal/load/pkg.go                     |  7 ++++++-
+ .../testdata/script/build_version_stamping_git.txt  | 13 +++++++++++++
+ 2 files changed, 19 insertions(+), 1 deletion(-)
+
+diff --git a/src/cmd/go/internal/load/pkg.go b/src/cmd/go/internal/load/pkg.go
+index 0c4639ce82..13add8ad5b 100644
+--- a/src/cmd/go/internal/load/pkg.go
++++ b/src/cmd/go/internal/load/pkg.go
+@@ -2563,7 +2563,12 @@ func (p *Package) setBuildInfo(ctx context.Context, autoVCS bool) {
+ 		vers := revInfo.Version
+ 		if vers != "" {
+ 			if st.Uncommitted {
+-				vers += "+dirty"
++				// SemVer build metadata is dot-separated https://semver.org/#spec-item-10
++				if strings.HasSuffix(vers, "+incompatible") {
++					vers += ".dirty"
++				} else {
++					vers += "+dirty"
++				}
+ 			}
+ 			info.Main.Version = vers
+ 		}
+diff --git a/src/cmd/go/testdata/script/build_version_stamping_git.txt b/src/cmd/go/testdata/script/build_version_stamping_git.txt
+index db804b3847..e7ca8d25df 100644
+--- a/src/cmd/go/testdata/script/build_version_stamping_git.txt
++++ b/src/cmd/go/testdata/script/build_version_stamping_git.txt
+@@ -108,6 +108,19 @@ go version -m example$GOEXE
+ stdout '\s+mod\s+example\s+v1.0.3-0.20220719150703-2e239bf29c13\s+'
+ rm example$GOEXE
+ 
++# Create +incompatible module
++exec git checkout v1.0.4
++exec git rm go.mod
++exec git commit -m 'commit 6'
++exec git tag v2.0.0
++exec git checkout HEAD^ go.mod
++# And make the tree +dirty
++mv README4 README5
++go build
++go version -m example$GOEXE
++stdout '\s+mod\s+example\s+v2.0.0+incompatible.dirty\s+'
++rm example$GOEXE
++
+ -- $WORK/repo/go.mod --
+ module example
+ 
+-- 
+2.43.0
+