Skip to content

go-1.24: fix go main version not semver compatible #43876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

go-1.24: fix go main version not semver compatible #43876

wants to merge 3 commits into from

Conversation

xnox
Copy link
Member

@xnox xnox commented Feb 26, 2025 •
edited
Loading

Fix +incompatible+dirty build metadata to be semver compatible.

With this change, rebuilding pulumi in #43877 makes it all work as expected

Also enable running the testsuite during build.

See: golang/go#71971

Submitted upstream at https://go-review.googlesource.com/c/go/+/652955/3

# apk add --allow-untrusted -X https://apk.cgr.dev/wolfi-presubmit/944c657b461f89a52b356d1e3ccae1c4aed980fc  go pulumi grype

# go version -m /usr/bin/pulumi  | grep -e pulumi
/usr/bin/pulumi: go1.24.0
	path	github.com/pulumi/pulumi/pkg/v3/cmd/pulumi
	mod	github.com/pulumi/pulumi/pkg/v3	v3.152.0+incompatible.dirty	
	dep	github.com/pulumi/appdash	v0.0.0-20231130102222-75f619a67231	h1:vkHw5I/plNdTr435cARxCW6q9gc0S/Yxz7Mkd38pOb0=
	dep	github.com/pulumi/esc	v0.10.0	h1:jzBKzkLVW0mePeanDRfqSQoCJ5yrkux0jIwAkUxpRKE=
	dep	github.com/pulumi/inflector	v0.1.1	h1:dvlxlWtXwOJTUUtcYDvwnl6Mpg33prhK+7mzeF+SobA=
	dep	github.com/pulumi/pulumi/sdk/v3	v3.151.0
	=>	github.com/pulumi/ssh-agent	v0.5.1	h1:7DT4FcZNHWBAp9BFI+k0+HeBYGWbJvilJ29ra/4FlRM=
	build	-ldflags="-X github.com/pulumi/pulumi/sdk/v3/go/common/version.Version=v3.152.0"

# grype /usr/bin/pulumi 
 ✔ Vulnerability DB                [updated]  
 ✔ Indexed file system                                                                                                                     /usr/bin/pulumi
 ✔ Cataloged contents                                                                     c1947d89c427ea46f21cf1963a8c446d6e668ec5d8d45bf85f912ff932abcb1e
   ├── ✔ Packages                        [212 packages]  
   ├── ✔ File digests                    [1 files]  
   ├── ✔ File metadata                   [1 locations]  
   └── ✔ Executables                     [1 executables]  
 ✔ Scanned for vulnerabilities     [0 vulnerability matches]  
   ├── by severity: 0 critical, 0 high, 0 medium, 0 low, 0 negligible
   └── by status:   0 fixed, 0 not-fixed, 0 ignored 
No vulnerabilities found

@octo-sts Octo STS

This comment was marked as resolved.

Sign in to view
@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Feb 26, 2025
@xnox xnox force-pushed the fix-go-incompatible-dirty branch from 37eeb03 to d1a4d41 Compare February 26, 2025 18:08
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Feb 26, 2025
@xnox xnox force-pushed the fix-go-incompatible-dirty branch from d1a4d41 to a8987cb Compare February 26, 2025 19:51
@imjasonh
Copy link
Member

I don't think we should carry this patch unless/until it's accepted upstream.

@xnox xnox force-pushed the fix-go-incompatible-dirty branch 2 times, most recently from 84853c1 to d16b951 Compare February 26, 2025 22:07
@xnox xnox requested a review from a team as a code owner February 26, 2025 22:49
@xnox xnox force-pushed the fix-go-incompatible-dirty branch 3 times, most recently from 22052eb to 6da1285 Compare February 26, 2025 23:06
smoser
smoser reviewed Feb 27, 2025
View reviewed changes
pipelines/strip.yaml Outdated
pipeline:
- working-directory: ${{targets.contextdir}}
runs: |
scanelf --recursive --nobanner --etype "ET_DYN,ET_EXEC" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shell sucks.
left side of this pipe fails silently and results in nothing being done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love for this to get put into chainguard-dev/tw

@xnox xnox force-pushed the fix-go-incompatible-dirty branch from 6da1285 to 5310694 Compare February 27, 2025 13:18
@xnox xnox force-pushed the fix-go-incompatible-dirty branch from 5310694 to b3d768f Compare February 27, 2025 22:12
@xnox
Copy link
Member Author

xnox commented Apr 25, 2025

Upstreaming these changes in:

@xnox xnox closed this Apr 25, 2025
@xnox
Copy link
Member Author

xnox commented Apr 29, 2025

@imjasonh this is now upstream in master & 1.24 stable branch see golang/go@c1f9c2c

@xnox
Copy link
Member Author

xnox commented May 6, 2025

This is now fixed in golang/go#73500 and thus also by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoser smoser smoser left review comments

Assignees
No one assigned
Labels
ai/skip-comment Stop AI from commenting on PR bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xnox @imjasonh @smoser