Skip to content

ECE: display notice on tax limitations #4172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

annemirasol
Copy link
Contributor

@annemirasol annemirasol commented Mar 31, 2025

Changes proposed in this Pull Request:

Background
When taxes are based on billing address, we are unable to compute accurate taxes for express checkout. This is because we do not have access to the billing address until after the payment is submitted, i.e. we receive it only on the confirm event.

Currently, we are choosing to hide express checkout when:

  • the product/cart is not shippable, e.g. virtual products
  • taxes are based on billing address

In this PR, we add a notice pill for express checkout methods, to inform the merchant that even when enabled, Apple Pay, Google Pay, and Link will not be available if the above conditions are true.

Note: Amazon Pay is not included in these changes, as we will be turning it off outright when taxes are based on billing address. See STRIPE-377

Screenshot 2025-03-31 at 4 19 57 PM

Testing instructions

TBD


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

Copy link

📈 PHP Unit Code Coverage Report

Package Line Rate Health
includes/admin/class-wc-stripe-settings-controller.php 20%
Summary 44% (6949 / 15806)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant