Fix JS test console warning #4242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two console warnings in JS tests by modifying the test setups in two test files.
- In the promotional banner section test, the original window.location.reload function is preserved and restored after each test run.
- In the display order customization notice test, the test callback is made asynchronous and the userEvent click is wrapped in an asynchronous act block to address timing concerns.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/settings/payment-settings/tests/promotional-banner-section.test.js | Preserves and restores window.location.reload to avoid test warnings. |
| client/settings/display-order-customization-notice/tests/display-order-customization-notice.js | Converts a test to async and wraps the userEvent.click in await act to address console warnings. |
Mayisha
requested review from
a team and
annemirasol
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR fixes the following two console warnings when JS tests are run locally.
Testing instructions
npm run test:jsand confirm that there is no warning message.