Using the new product type constants #4303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrosa
changed the base branch from
develop
to
dev/updating-the-min-wc-version-to-9.8
…the-new-product-type-constants
wjrosa
added
the
status: blocked
|
Closing in favor of #4474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
New constants for product types have been available since WooCommerce version 9.8. This PR implements those on the Stripe extension code. It also updates the minimum WC (and the future minimum) to avoid issues.
Testing instructions
Code review. Check if the tests are still passing.
Changelog entry
Changelog Entry Comment
Comment
Post merge