Add hook to allow for custom webhook post-processing #4466
Conversation
| /** | ||
| * Fires after a webhook has been processed, but before we respond to Stripe. | ||
| * This allows for custom processing of the webhook after it has been processed. | ||
| * | ||
| * @since 9.7.0 | ||
| * | ||
| * @param string $webhook_type The type of webhook that was processed. | ||
| * @param object $notification The webhook data sent from Stripe. | ||
| */ | ||
| do_action( 'wc_stripe_webhook_processed', (string) $notification->type, $notification ); |
There was a problem hiding this comment.
It feels like we should also include an order reference where possible.
There was a problem hiding this comment.
payment_intent.succeeded and payment_intent.amount_capturable_updated events might be processed async
Without a major refactor, what we can do is exclude those events from this action, and do something similar to what was done for the do_action( 'wc_gateway_stripe_process_payment', $charge, $order ) call, which is called in both cases with the same params (the charge and the order):
Specifically for the request in STRIPE-564, the existing action might give them the info they want (it's called with the latest charge)
There was a problem hiding this comment.
We might want to wrap the hook in a try/catch (and log the error on failure) so that it doesn't interrupt rest of the flow if something fails within the hook.
Towards STRIPE-564
Changes proposed in this Pull Request:
This PR proposes the addition of a new
wc_stripe_webhook_processedaction that is triggered just after we process an inbound webhook from Stripe. This will make it easier for merchants and developers to include more details in WooCommerce based on the data from Stripe. The initial use case for this is to include more data for charges to allow for easier fraud detection while processing orders.Testing instructions
TBD
Changelog entry
Changelog Entry Comment
Comment
Post merge