Fix wrong price formatting in Apple/Google Pay #4480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayisha
changed the title
Mayisha
requested review from
a team,
malithsen and
wjrosa
and removed request for
a team
wjrosa
reviewed
Jul 14, 2025
wjrosa
reviewed
Jul 14, 2025
wjrosa
reviewed
Jul 14, 2025
includes/payment-methods/class-wc-stripe-express-checkout-helper.php
Outdated
Show resolved
Hide resolved
wjrosa
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Left some optional comments. It works as expected, but when I attempt to add a product slightly cheaper than the $18 amount (the mocked beanie product with discount) I get the error below in console and the buttons are not present:
Not directly related I guess, but might be worth fixing it if that's something simple to do here.
malithsen
reviewed
Jul 14, 2025
malithsen
approved these changes
Jul 16, 2025
📈 PHP Unit Code Coverage Report
|
malithsen
pushed a commit
that referenced
this pull request
Jul 17, 2025
* make 'three_decimal_currencies' method public * use currency decimal supported in Stripe * add changelog * remove unnecessary else * convert currency to lower case * add test for test_get_stripe_currency_decimals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes STRIPE-573
Fixes #4479
Changes proposed in this Pull Request:
currency_decimalsinstead of what's saved in the WooCommerce settings.Testing instructions
USDas the store currency0as the Number of decimalsdevelop, notice that Google/Apple Pay is not presentdevelop, notice that, Google/Apple Pay is now present on the checkout page. But when you click the express checkout button, notice that the displayed price is wrong.JPYand confirm that the price is correct on Google/Apple Pay and Link modals for JPY.