Disabling BNPLs when other official plugins are active #4492

wjrosa · 2025-07-14T21:43:56Z

Changes proposed in this Pull Request:

To prevent Affirm and Klarna from being displayed alongside other official plugins, we are now removing them when the other plugins are active. Instead of checking for any of the plugins, we are disabling each corresponding method.

I am also adding some new helper methods specific to this logic to reduce duplicate code.

Testing instructions

Checkout to the develop branch on your test environment
Connect a US Stripe account
Install Affirm or Klarna extensions (only one is enough)
Confirm you can see Klarna and Affirm in the payment methods settings page (wp-admin/admin.php?page=wc-settings&tab=checkout&section=stripe&panel=methods)
Enable both
As a shopper, add at least 50 USD in products to your cart
Go to the checkout page and confirm both methods are available
Now checkout to this branch instead (update/disable-bnpls-when-other-plugins-are-active)
As a shopper, confirm Klarna and Affirm are now gone from the payment methods settings page (depending on the official extension you installed, or both if you installed both)
As a merchant, go to the checkout page and confirm that the same happened

Covered with tests (or have a good reason not to test in description ☝️)
Tested on mobile (or does not apply)

Changelog entry

This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Comment

Comment

Post merge

Added testing instructions to the Release Testing Instructions wiki page (or does not apply)
Added the needs docs label (or does not apply)
Included this PR in the Release Thread scope (or does not apply)

wjrosa · 2025-07-14T21:45:39Z

includes/class-wc-stripe-helper.php

+	 *
+	 * @return bool
+	 */
+	public static function has_other_bnpl_plugins_active() {


Since we need this logic in multiple places, I moved it to a new helper function.

wjrosa · 2025-07-14T21:45:53Z

includes/notes/class-wc-stripe-bnpl-promotion-note.php

-			}
-		}
-		if ( $has_other_bnpl_plugins_active ) {
+		if ( WC_Stripe_Helper::has_other_bnpl_plugins_active() ) {


Making use of the new helper function.

wjrosa · 2025-07-14T21:46:04Z

includes/admin/class-wc-stripe-settings-controller.php

@@ -287,7 +278,7 @@ public function admin_scripts( $hook_suffix ) {
 			'is_oc_available'                       => WC_Stripe_Feature_Flags::is_oc_available(),
 			'oauth_nonce'                           => wp_create_nonce( 'wc_stripe_get_oauth_urls' ),
 			'is_sepa_tokens_enabled'                => 'yes' === $this->gateway->get_option( 'sepa_tokens_for_other_methods', 'no' ),
-			'has_other_bnpl_plugins'                => $has_other_bnpl_plugins_active,
+			'has_other_bnpl_plugins'                => WC_Stripe_Helper::has_other_bnpl_plugins_active(),


Making use of the new helper function.

…re-active

Copilot

Pull Request Overview

This PR disables Stripe’s UPE BNPL methods (Affirm & Klarna) when the corresponding official plugins are active and centralizes the detection logic in helper methods.

Introduces has_gateway_plugin_active and has_other_bnpl_plugins_active with constants for official plugin IDs.
Updates UPE payment gateway, promotion note, and settings controller to use the new helpers.
Adds/testing adjustments for the new helpers and updates changelog/readme and client-side JS to remove BNPL methods.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/phpunit/WC_Stripe_Helper_Test.php	Replaces old tests, adds tests for `has_other_bnpl_plugins_active` and `has_gateway_plugin_active`.
readme.txt	Adds entry about disabling BNPL when official plugins are active.
includes/payment-methods/class-wc-stripe-upe-payment-gateway.php	Skips Affirm/Klarna methods via new helper checks.
includes/notes/class-wc-stripe-bnpl-promotion-note.php	Uses `has_other_bnpl_plugins_active` instead of manual loop.
includes/class-wc-stripe-helper.php	Adds constants and helper methods for plugin detection.
includes/admin/class-wc-stripe-settings-controller.php	Removes manual checks and localizes flags with new helper methods.
client/settings/general-settings-section/payment-methods-list.js	Removes BNPL methods in the UI when official plugins are active.
changelog.txt	Reflects the BNPL disabling feature.

Comments suppressed due to low confidence (4)

tests/phpunit/WC_Stripe_Helper_Test.php:222

The data provider key 'payment gateways' should be 'payment_gateways' to exactly match the test method’s $payment_gateways parameter name.

				'payment gateways' => [

tests/phpunit/WC_Stripe_Helper_Test.php:273

The data provider key 'plugin id' should be 'plugin_id' to align with the test method’s $plugin_id parameter name.

				'plugin id'        => WC_Stripe_Helper::OFFICIAL_PLUGIN_ID_KLARNA,

tests/phpunit/WC_Stripe_Helper_Test.php:274

Also update this key from 'payment gateways' to 'payment_gateways' so PHPUnit can map it to the $payment_gateways parameter.

				'payment gateways' => [

client/settings/general-settings-section/payment-methods-list.js:194

Import PAYMENT_METHOD_AFFIRM from 'wcstripe/stripe-utils/constants' at the top of the file, since it’s referenced here but not imported.

		availablePaymentMethods.includes( PAYMENT_METHOD_AFFIRM )

wjrosa · 2025-07-15T13:51:52Z

includes/admin/class-wc-stripe-settings-controller.php

-			'has_other_bnpl_plugins'                => $has_other_bnpl_plugins_active,
+			'has_affirm_gateway_plugin'             => WC_Stripe_Helper::has_gateway_plugin_active( WC_Stripe_Helper::OFFICIAL_PLUGIN_ID_AFFIRM ),
+			'has_klarna_gateway_plugin'             => WC_Stripe_Helper::has_gateway_plugin_active( WC_Stripe_Helper::OFFICIAL_PLUGIN_ID_KLARNA ),
+			'has_other_bnpl_plugins'                => WC_Stripe_Helper::has_other_bnpl_plugins_active(),


Another option here would be to reuse the return of both WC_Stripe_Helper::has_gateway_plugin_active. Not sure if it is worth it.

diegocurbelo

After installing and enabling the WooCommerce Gateway Affirm plugin:

As a shopper, confirm Klarna and Affirm are now gone from the payment methods settings page (depending on the official extension you installed, or both if you installed both)

This works as indicated; the Stripe payment method is no longer shown in the payment method list in the settings.

As a merchant, go to the checkout page and confirm that the same happened

But it's still visible in the checkout.

--

Additionally, removing the Affirm/Klarna methods from the payment method list in the settings without providing any feedback may be confusing.

Maybe we can set it as disabled and add a yellow pill, similar to the one we use for "Requires activation"?

Or show a notice or message explaining why Affirm/Klarna are not available in the list, or group them at the bottom under an 'Unavailable Payment Methods' group?

Mayisha · 2025-07-16T05:49:13Z

Additionally, removing the Affirm/Klarna methods from the payment method list in the settings without providing any feedback may be confusing.
Maybe we can set it as disabled and add a yellow pill, similar to the one we use for "Requires activation"?
Or show a notice or message explaining why Affirm/Klarna are not available in the list, or group them at the bottom under an 'Unavailable Payment Methods' group?

+1 to this. Completely removing the payment methods could be confusing for the user. I like the idea of showing it disabled, preferably with a tooltip explaining the reason for it being disabled.

…re-active

tests/phpunit/WC_Stripe_Helper_Test.php

includes/class-wc-stripe-helper.php

wjrosa · 2025-07-16T16:47:52Z

Thanks for the reviews, folks!

Maybe we can set it as disabled and add a yellow pill, similar to the one we use for "Requires activation"?

Makes sense. I went for this option in my latest commits. Preview here:

I have also fixed the methods availability in both the shortcode and block checkout.

…re-active

annemirasol

This looks good and works as expected. Left a suggestion about the wording in the pill.

Tested:

When official plugin is installed and active:
✅ Klarna unavailable in settings, and not shown in block/classic checkout
✅ Affirm unavailable in settings, and not shown in block/classic checkout

When official plugin is not enabled:
✅ Klarna available in settings, and shown in block/classic checkout if enabled
✅ Affirm available in settings, and shown in block/classic checkout if enabled

Noting our earlier discussion where in a future iteration, we may also disable Klarna/Affirm in the merchant's PMC. Right now, they are disabled for the store when a conflict exists, but they remain enabled in the PMC, even after a settings update.

client/components/payment-method-unavailable-due-conflict-pill/index.js

annemirasol · 2025-07-16T19:23:13Z

Noting our earlier discussion where in a future iteration, we may also disable Klarna/Affirm in the merchant's PMC. Right now, they are disabled for the store when a conflict exists, but they remain enabled in the PMC, even after a settings update.

Actually, I want to double-check that I am understanding the earlier discussion correctly. This is the flow I'm wondering about:

Enable Klarna.
Install the other plugin and enable it.
Notice how Klarna is now unavailable and disabled in Stripe settings.
Enable or disable some other payment method, and click "Save changes".
Notice in your Stripe dashboard that Klarna is still enabled.

We are okay with this flow, and will update things for OC, is that correct?

…re-active

wjrosa · 2025-07-16T20:06:38Z

Noting our earlier discussion where in a future iteration, we may also disable Klarna/Affirm in the merchant's PMC. Right now, they are disabled for the store when a conflict exists, but they remain enabled in the PMC, even after a settings update.

Actually, I want to double-check that I am understanding the earlier discussion correctly. This is the flow I'm wondering about:

Enable Klarna.

Install the other plugin and enable it.

Notice how Klarna is now unavailable and disabled in Stripe settings.

Enable or disable some other payment method, and click "Save changes".

Notice in your Stripe dashboard that Klarna is still enabled.

We are okay with this flow, and will update things for OC, is that correct?

Thanks for the review, Anne! Yes, that's my understanding as well

malithsen

Looks good!

✅ Tested settings page with Klarna/Affirm official plugins active/inactive.
✅ Tested checkout pages (Blocks/Classic) with official plugins active/inactive.

github-actions · 2025-07-16T21:24:48Z

📈 PHP Unit Code Coverage Report

Package	Line Rate	Health
includes/admin/class-wc-stripe-settings-controller.php	18%	❌
includes/class-wc-stripe-helper.php	61%	➖
includes/notes/class-wc-stripe-bnpl-promotion-note.php	65%	➖
includes/payment-methods/class-wc-stripe-upe-payment-gateway.php	48%	❌
includes/payment-methods/class-wc-stripe-upe-payment-method-affirm.php	97%	✔
includes/payment-methods/class-wc-stripe-upe-payment-method-klarna.php	57%	❌
Summary	45% (7621 / 16998)	❌

* Disabling BNPLs when other official plugins are active * Simplifying logic * Changelog and readme entries * Unit tests * Checking for specific official plugins instead of any * Adding constants * Unit test * Fix methods availability in the block checkout * Fix methods availability in the block checkout * Keeping methods visible in the settings page * Fix methods availability in the shortcode checkout * New pill to inform about the conflict * Unit test * Disable checkbox when unavailable * Reverting unit tests removal * Update index.js * Update index.test.js * Update index.js

Disabling BNPLs when other official plugins are active

e18b8a9

wjrosa self-assigned this Jul 14, 2025

wjrosa commented Jul 14, 2025

View reviewed changes

wjrosa added 3 commits July 15, 2025 07:55

Simplifying logic

fc3d51a

Changelog and readme entries

e90b2d3

Unit tests

19d0206

wjrosa marked this pull request as ready for review July 15, 2025 12:44

wjrosa added 5 commits July 15, 2025 10:20

Checking for specific official plugins instead of any

de89343

Adding constants

82fcb80

Unit test

21f2457

Merge branch 'develop' into update/disable-bnpls-when-other-plugins-a…

d6f85d2

…re-active

Merge branch 'develop' into update/disable-bnpls-when-other-plugins-a…

569443d

…re-active

wjrosa requested a review from Copilot July 15, 2025 13:43

Copilot AI reviewed Jul 15, 2025

View reviewed changes

wjrosa requested review from a team, diegocurbelo and Mayisha and removed request for a team July 15, 2025 13:49

wjrosa commented Jul 15, 2025

View reviewed changes

diegocurbelo requested changes Jul 15, 2025

View reviewed changes

wjrosa requested review from annemirasol and malithsen July 16, 2025 14:16

Merge branch 'develop' into update/disable-bnpls-when-other-plugins-a…

644c10a

…re-active

annemirasol reviewed Jul 16, 2025

View reviewed changes

tests/phpunit/WC_Stripe_Helper_Test.php Outdated Show resolved Hide resolved

malithsen added this to the 9.7.0 milestone Jul 16, 2025

wjrosa added 2 commits July 16, 2025 13:03

Fix methods availability in the block checkout

6465faf

Fix methods availability in the block checkout

c2dfbc9

Keeping methods visible in the settings page

c33624d

malithsen reviewed Jul 16, 2025

View reviewed changes

includes/class-wc-stripe-helper.php Show resolved Hide resolved

wjrosa added 4 commits July 16, 2025 13:16

Fix methods availability in the shortcode checkout

7d76068

New pill to inform about the conflict

ce86f94

Unit test

3b5160d

Disable checkbox when unavailable

4f94543

wjrosa requested a review from diegocurbelo July 16, 2025 16:48

wjrosa added 2 commits July 16, 2025 13:48

Merge branch 'develop' into update/disable-bnpls-when-other-plugins-a…

3760220

…re-active

Reverting unit tests removal

4a26e67

wjrosa requested a review from annemirasol July 16, 2025 16:53

annemirasol approved these changes Jul 16, 2025

View reviewed changes

client/components/payment-method-unavailable-due-conflict-pill/index.js Outdated Show resolved Hide resolved

wjrosa added 3 commits July 16, 2025 17:03

Update index.js

b5fc2a5

Update index.test.js

ed7c159

Merge branch 'develop' into update/disable-bnpls-when-other-plugins-a…

9bcd50f

…re-active

Update index.js

7144812

malithsen approved these changes Jul 16, 2025

View reviewed changes

wjrosa merged commit 8f01d94 into develop Jul 16, 2025
49 of 50 checks passed

wjrosa deleted the update/disable-bnpls-when-other-plugins-are-active branch July 16, 2025 21:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Disabling BNPLs when other official plugins are active #4492

Disabling BNPLs when other official plugins are active #4492

Uh oh!

wjrosa commented Jul 14, 2025 •

edited

Loading

Uh oh!

wjrosa Jul 14, 2025

Uh oh!

wjrosa Jul 14, 2025

Uh oh!

wjrosa Jul 14, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

wjrosa Jul 15, 2025

Uh oh!

diegocurbelo left a comment

Uh oh!

Mayisha commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

wjrosa commented Jul 16, 2025

Uh oh!

annemirasol left a comment

Uh oh!

Uh oh!

annemirasol commented Jul 16, 2025

Uh oh!

wjrosa commented Jul 16, 2025

Uh oh!

malithsen left a comment

Uh oh!

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Uh oh!

Disabling BNPLs when other official plugins are active #4492

Disabling BNPLs when other official plugins are active #4492

Uh oh!

Conversation

wjrosa commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request:

Testing instructions

Changelog entry

Comment

Uh oh!

wjrosa Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

wjrosa Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

wjrosa Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

wjrosa Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

diegocurbelo left a comment

Choose a reason for hiding this comment

Uh oh!

Mayisha commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

wjrosa commented Jul 16, 2025

Uh oh!

annemirasol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

annemirasol commented Jul 16, 2025

Uh oh!

wjrosa commented Jul 16, 2025

Uh oh!

malithsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 16, 2025

📈 PHP Unit Code Coverage Report

Uh oh!

Uh oh!

wjrosa commented Jul 14, 2025 •

edited

Loading