Skip to content

Conversation

@wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Nov 4, 2025

Changes proposed in this Pull Request:

In this PR, I am deprecating the is_upe_preview_enabled method and removing the actual feature flag (_wcstripe_feature_upe). This has not been used for a while, since we deprecated the legacy checkout. I am also updating all parts of the code referencing the is_upe_preview_enabled method.

Testing instructions

Code review. Check if the tests are still passing. Perform some basic smoke-testing.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Nov 4, 2025
@wjrosa wjrosa marked this pull request as ready for review November 6, 2025 19:17
@wjrosa wjrosa requested review from a team, diegocurbelo and malithsen and removed request for a team November 6, 2025 19:37
Co-authored-by: Diego Curbelo <diego@curbelo.com>
@wjrosa wjrosa changed the title Deprecating the UPE preview feature flag and remove its usages Deprecating the UPE preview feature flag and removing its usages Nov 7, 2025
@wjrosa wjrosa requested a review from diegocurbelo November 7, 2025 11:52
Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Tests are failing. It doesn't look like failures are related to the changes in this PR, though we'd still want to figure out why they are failing before merging.

@wjrosa
Copy link
Contributor Author

wjrosa commented Nov 13, 2025

@malithsen, it looks like something related to Composer itself or PHPUnit with PHP 7.4. I tried to update the version of the setup-php action to the latest, but that did not fix the issue. I see the same failures on other PRs. I will spend a bit more time trying to understand the root cause later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants