-
Notifications
You must be signed in to change notification settings - Fork 216
Deprecating the UPE preview feature flag and removing its usages #4760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Deprecating the UPE preview feature flag and removing its usages #4760
Conversation
Co-authored-by: Diego Curbelo <diego@curbelo.com>
Co-authored-by: Malith Senaweera <6216000+malithsen@users.noreply.github.com>
malithsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me. Tests are failing. It doesn't look like failures are related to the changes in this PR, though we'd still want to figure out why they are failing before merging.
|
@malithsen, it looks like something related to Composer itself or PHPUnit with PHP 7.4. I tried to update the version of the |
Changes proposed in this Pull Request:
In this PR, I am deprecating the
is_upe_preview_enabledmethod and removing the actual feature flag (_wcstripe_feature_upe). This has not been used for a while, since we deprecated the legacy checkout. I am also updating all parts of the code referencing theis_upe_preview_enabledmethod.Testing instructions
Code review. Check if the tests are still passing. Perform some basic smoke-testing.
Changelog entry
Changelog Entry Comment
Comment
Post merge