-
Notifications
You must be signed in to change notification settings - Fork 117
Open
Labels
feature: order detailsRelated to order details.Related to order details.type: enhancementA request for an enhancement.A request for an enhancement.type: taskAn internally driven task.An internally driven task.type: technical debtRepresents or solves tech debt of the project.Represents or solves tech debt of the project.
Description
Currently there's 25+ calls to ServiceLocator
in OrderDetailsViewModel
that are mainly used for tracking events. We should inject the analytics provider directly rather than reaching for the shared instance.
This also causes that track events have to be tested with setups like:
let analytics = ServiceLocator.analytics.analyticsProvider as! MockAnalyticsProvider
Metadata
Metadata
Assignees
Labels
feature: order detailsRelated to order details.Related to order details.type: enhancementA request for an enhancement.A request for an enhancement.type: taskAn internally driven task.An internally driven task.type: technical debtRepresents or solves tech debt of the project.Represents or solves tech debt of the project.